Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: TestStdioAreInheritable fails on windows-arm64-aws because it tries to build a library using an unsupported build mode #46582

Open
dmitshur opened this issue Jun 5, 2021 · 1 comment

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jun 5, 2021

The new-to-Go 1.17 windows/arm64 port (#36439) at this time doesn't support the c-shared build mode (#46549). TestStdioAreInheritable was added in CL 316269 and currently makes use of the c-shared build mode:

cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", dll, "-buildmode", "c-shared", dllsrc)
out, err := testenv.CleanCmdEnv(cmd).CombinedOutput()
if err != nil {
t.Fatalf("failed to build go library: %s\n%s", err, out)
}

​The test fails on windows/arm64 as detected by the windows-arm64-aws builder:

--- FAIL: TestStdioAreInheritable (0.08s)
   ​syscall_windows_test.go:110: failed to build go library: exit status 1
       ​-buildmode=c-shared not supported on windows/arm64
FAIL
FAIL	syscall	0.353s

Source: https://storage.googleapis.com/go-build-log/78592762/windows-arm64-aws_f90b24c9.log from CL 323991.

The test can be skipped on windows/arm64 since that port doesn't meet the minimum requirements (CL 323992 adds this skip). Perhaps the test can be updated not to require c-shared build mode. As another option, the test may stop failing if the c-shared build mode gets enabled for windows/arm64 port.

CC @alexbrainman, @ianlancetaylor.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 5, 2021

Change https://golang.org/cl/323992 mentions this issue: syscall: skip TestStdioAreInheritable when c-shared is unsupported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants