encoding/json: struct tags to ignore fields don't work on unexported fields

[bradfitz]

The json annotations to both ignore and rename fields don't work for unexported fields.


Example:


package main

import (
        "encoding/json"
        "log"
)

type T struct {
        Name string
        m    map[string]interface{} `json:"-"`
        m2   map[string]interface{} `json:"sldkjfsd"`
}

func main() {
        input := `{"Name": "Bob", "m": {"x": 123}, "m2": {"y": 456}}`
        t := &T{}
        err := json.Unmarshal([]byte(input), t)
        log.Printf("Name %q; err: %v", t.Name, err)
}

Generates:

2013/01/14 17:17:11 Name "Bob"; err: json: cannot unmarshal object key
"m" into unexported field m of type main.T

Interestingly, the first case "m" works with Go 1.0.3 and only fails with tip.

But "m2" fails with both 1.0.3 and tip.

[rsc]

Comment 1:

I am inclined to say that the Go 1.0.3 behavior is correct and that the only regression
here is the `json:"-"` being incorrectly ignored at tip.
One could argue for ignoring the unexported fields entirely, but then people ask why
Unmarshal is silently doing nothing. I think the error does help most people.

Labels changed: added priority-later, removed priority-triage.

[bradfitz]

Comment 2:

That's a bit unfortunate, in that you can then never safely unmarshal into a struct
containing unexported fields if you can't be certain the input will never contain those
field names in the future.
I just had a split a type into two because of this.
Oh well.  At least this works:
type TInner struct {
        Name string
}
type T struct {
        TInner
        m    map[string]interface{}
        m2   map[string]interface{}
}
func main() {
        input := `{"Name": "Bob", "m": {"x": 123}, "m2": {"y": 456}}`
        var t T
        err := json.Unmarshal([]byte(input), &t.TInner)
        log.Printf("Name %q; err: %v", t.Name, err)
}

[gopherbot]

Comment 3 by rickarnoldjr:

Fixed by https://golang.org/cl/7139049/

[adg]

Comment 4:

Thanks Rick, but it's not fixed until the fix is submitted. :-)

Status changed to Started.

[adg]

Comment 5:

I am inclined to agree with Brad. I think encoding/json should behave as if unexported
fields do not exist.

[rsc]

Comment 6:

Okay, let's try it.

[rsc]

Comment 7:

This issue was closed by revision 6e3f3af.

Status changed to Fixed.