Skip to content

x/tools/gopls: include modifiers in completion candidate labels #46671

Open
@muirdm

Description

@muirdm

Consider whether gopls should include full expressions in candidate labels. For example:

var foo func() int
var bar *int
var _ int = <>

At <> we currently offer candidates with labels foo and bar (as of https://go-review.googlesource.com/c/tools/+/323449), but they are inserted as foo() and *bar. We could change their labels to foo() and *bar, respectively.

There will be lots of test fallout from this change. We should consider changing the mark based completion tests to depend less directly on the candidate labels.

/cc @findleyr

Metadata

Metadata

Assignees

No one assigned

    Labels

    ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions