Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/mod_invalid_version fails on Windows #46691

Closed
bcmills opened this issue Jun 10, 2021 · 1 comment
Closed

cmd/go: TestScript/mod_invalid_version fails on Windows #46691

bcmills opened this issue Jun 10, 2021 · 1 comment

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jun 10, 2021

go test proxy running at GOPROXY=http://127.0.0.1:60426/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/mod_invalid_version (0.23s)
        script_test.go:252:
            # Regression test for golang.org/issue/27173: if the user (or go.mod file)
            # requests a pseudo-version that does not match both the module path and commit
            # metadata, reject it with a helpful error message.
            #
            # TODO(bcmills): Replace the github.com/pierrec/lz4 examples with something
            # equivalent on vcs-test.golang.org.
            # An incomplete commit hash is not a valid semantic version,
            # but can appear in the main go.mod file anyway and should be resolved. (0.202s)
            > cp go.mod.orig go.mod
            > go mod edit -require golang.org/x/text@14c0d48ead0c
            > cd outside
            $WORK\gopath\src\outside
            > ! go list -m golang.org/x/text
            [stderr]
            go list -m: example.com@v0.0.0 (replaced by ./..): parsing ..\go.mod: $WORK\gopath\src\go.mod:5: require golang.org/x/text: version "14c0d48ead0c" invalid: must be of the form v1.2.3
            [exit status 1]
            > stderr 'go list -m: example.com@v0.0.0 \(replaced by \./\..\): parsing ../go.mod: '$WORK'/gopath/src/go.mod:5: require golang.org/x/text: version "14c0d48ead0c" invalid: must be of the form v1.2.3'
            FAIL: testdata\script\mod_invalid_version.txt:22: no match for `(?m)go list -m: example.com@v0.0.0 \(replaced by \./\..\): parsing ../go.mod: \$WORK/gopath/src/go.mod:5: require golang.org/x/text: version "14c0d48ead0c" invalid: must be of the form v1.2.3` found in stderr

FAIL
FAIL    cmd/go  626.033s
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 10, 2021

Change https://golang.org/cl/326869 mentions this issue: cmd/go: match Windows paths in TestScript/mod_invalid_version

@gopherbot gopherbot closed this in 2f11284 Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants