Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: windows-*-longtest builders have no Git binary in %PATH% #46693

Open
bcmills opened this issue Jun 10, 2021 · 1 comment
Open

x/build: windows-*-longtest builders have no Git binary in %PATH% #46693

bcmills opened this issue Jun 10, 2021 · 1 comment

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jun 10, 2021

I got a shiny new Windows laptop for personal use, and out of curiosity I decided to install the Go toolchain and run go test cmd/go on it.

Unfortunately, that immediately uncovered two existing test failures (#46692 and #46691) that had not shown up in the Go project's builders — even the longtest builders.

The common, relevant factor between the two failing tests is this line:

[!exec:git] skip

That seems to imply that either the Go windows-amd64-longtest builder does not have a git binary installed, or that git binary is omitted from %PATH% when the cmd/go tests are run.

This seems like a pretty substantial (and unexpected) gap in test coverage, but hopefully it is pretty easy to fix. However, it may reveal issues that need to be fixed in previous releases. (For a start, we may need to backport the GCM_INTERACTIVE portion of CL 300157.)

CC @golang/release

@bcmills
Copy link
Member Author

@bcmills bcmills commented Jun 11, 2021

Per #46692, I think we should configure git on the Windows builders with core.longpaths set to true.

@dmitshur dmitshur added this to Planned in Go Release Team Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants