Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/trace: TestAnalyzeAnnotations failures on linux/riscv64 #46737

Open
bcmills opened this issue Jun 14, 2021 · 5 comments
Open

cmd/trace: TestAnalyzeAnnotations failures on linux/riscv64 #46737

bcmills opened this issue Jun 14, 2021 · 5 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jun 14, 2021

--- FAIL: TestAnalyzeAnnotations (0.01s)
    annotations_test.go:136: got task task 1:	task0
        	start: 496007 end: 768012 complete: true
        	2 goroutines
        	4 regions:
        		task0.region0(goid=12)
        		(goid=13)
        		task0.region2(goid=13)
        		task0.region1(goid=13)
        	1 children:
        		task1
        ; want {complete:true goroutines:2 regions:[task0.region0  task0.region1 task0.region2]}
FAIL
FAIL	cmd/trace	0.815s

2021-06-13T08:17:17-24cff0f/linux-riscv64-unleashed
2021-04-27T15:57:56-bc62887/linux-riscv64-jsing
2021-04-06T14:15:29-b345a30/linux-riscv64-jsing
2021-04-02T01:14:00-97b3ce4/linux-riscv64-jsing
2021-03-22T03:52:31-d8394bf/linux-riscv64-jsing
2020-05-05T05:13:26-9b18968/linux-riscv64-unleashed
2020-04-25T02:19:12-49f10f3/linux-riscv64-unleashed

CC @prattmic @mknyszek @4a6f656c @bradfitz

@bcmills bcmills added this to the Backlog milestone Jun 14, 2021
@bcmills bcmills changed the title cmd/trace: TestAnalyzeAnnotations failures on linux-riscv64 cmd/trace: TestAnalyzeAnnotations failures on linux/riscv64 Jun 14, 2021
@mengzhuo
Copy link
Contributor

@mengzhuo mengzhuo commented Jun 21, 2021

This affected Hifive unmatched too.
I've tried to bisect unfortunately it is bad since go1.14(20a838a)

@bcmills
Copy link
Member Author

@bcmills bcmills commented Jun 22, 2021

Would it make sense to skip this test on the riscv64 builders until it can be diagnosed? The failure rate is high enough that it could be masking other failures on these builders.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 25, 2021

Change https://golang.org/cl/330849 mentions this issue: cmd/trace: ensure at least 1 tick between events

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 9, 2021

Change https://golang.org/cl/333449 mentions this issue: cmd/trace: ensure at least 1 tick between events

@bcmills
Copy link
Member Author

@bcmills bcmills commented Jul 12, 2021

@hyangah, could you take a look at the fix for this? It's at +1, and would be nice to get in a fix for the underlying problem before the Go 1.17 release.

@bcmills bcmills removed this from the Backlog milestone Jul 12, 2021
@bcmills bcmills added this to the Go1.17 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants