Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: TestMorestack failures on darwin/arm64 #46755

Closed
bcmills opened this issue Jun 15, 2021 · 4 comments
Closed

runtime/pprof: TestMorestack failures on darwin/arm64 #46755

bcmills opened this issue Jun 15, 2021 · 4 comments
Labels
arch-arm64 FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Jun 15, 2021

2021-06-15T10:13:08-abc56fd/darwin-arm64-11_0-toothrot
2021-04-30T00:32:42-303b194/darwin-arm64-11_0-toothrot

See previously #44418 (CC @cherrymui).

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-arm64 labels Jun 15, 2021
@bcmills bcmills added this to the Go1.17 milestone Jun 15, 2021
@bcmills
Copy link
Member Author

bcmills commented Jun 15, 2021

Marking as release-blocker for 1.17 because the tests are newly unskipped on Darwin as of CL 292229 (CC @golang/release).

If it isn't important that the tests pass on this platform for 1.17, it seems ok to unblock the release by adding a skip on this builder platform (GOOS + GOARCH), although fixing the test would be better still.

@prattmic
Copy link
Member

prattmic commented Jun 18, 2021

Perhaps we just need to increase the stack growth time even more than http://golang.org/cl/307730?

@cherrymui
Copy link
Member

Yeah, probably. Changed copying size from 8<<16 to 8<<18, it seems to pass on my Apple M1 machine reliably with 1000 runs. I'll send a CL.

@gopherbot
Copy link

Change https://golang.org/cl/329869 mentions this issue: runtime/pprof: deflake TestMorestack more

@golang golang locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Projects
None yet
Development

No branches or pull requests

4 participants