Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: adding linux-riscv64-unmatched builder #46804

Closed
mengzhuo opened this issue Jun 17, 2021 · 12 comments
Closed

x/build: adding linux-riscv64-unmatched builder #46804

mengzhuo opened this issue Jun 17, 2021 · 12 comments
Labels
Builders NeedsFix new-builder
Milestone

Comments

@mengzhuo
Copy link
Contributor

@mengzhuo mengzhuo commented Jun 17, 2021

According to #41956 and @cagedmantis suggestion.

I’m requesting builder linux-riscv64-unmatched

@gopherbot gopherbot added the Builders label Jun 17, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jun 17, 2021
@cagedmantis cagedmantis added NeedsDecision new-builder labels Jun 17, 2021
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jun 17, 2021

/cc @golang/release

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 18, 2021

Change https://golang.org/cl/329489 mentions this issue: dashboard: add linux-riscv64-unmatched

@4a6f656c
Copy link
Contributor

@4a6f656c 4a6f656c commented Jun 18, 2021

It would be good to understand what the plan is for linux/riscv64 builders moving forward - currently there are two already (although the linux-riscv64-unleashed builder was absent for a long time and appears to have disappeared again). There seems to be limited value in running multiple builders for the same platform, if they're doing the same work. Obviously the unmatched hardware will be slightly faster CPU-wise and a lot faster I/O-wise - if this hardware is available perhaps we should run this and turn off the existing two once stable?

(the other option would be to look at sharding the workloads, but that has its own sets of challenges)

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jun 18, 2021

It's hard to have a concrete plan, since these builders are reverse and depend on people running them. Having multiple builders for the same platform can help if one goes missing, another can still provide coverage. Having them share workload would likely be better, but we don't have good support for that.

if this hardware is available perhaps we should run this and turn off the existing two once stable?

That seems reasonable to me.

Also CC @bradfitz who's the owner of host-linux-riscv64-unleashed.

@4a6f656c
Copy link
Contributor

@4a6f656c 4a6f656c commented Jun 18, 2021

It's hard to have a concrete plan, since these builders are reverse and depend on people running them. Having multiple builders for the same platform can help if one goes missing, another can still provide coverage. Having them share workload would likely be better, but we don't have good support for that.

Running two might make sense, but I certainly doubt three is beneficial - even with one, if that disappears for a period of time, we can readily get a replacement online (especially now that the hardware is more readily available).

if this hardware is available perhaps we should run this and turn off the existing two once stable?

That seems reasonable to me.

Sounds like a plan.

Also CC @bradfitz who's the owner of host-linux-riscv64-unleashed.

@dmitshur dmitshur added NeedsFix and removed NeedsDecision labels Aug 10, 2021
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 10, 2021

If this offer still stands @mengzhuo, I think we can proceed. Has a builder key already been provided, or does that need to happen? I can review CL 329489 this week.

@mengzhuo
Copy link
Contributor Author

@mengzhuo mengzhuo commented Aug 26, 2021

@dmitshur @golang/release I'd happy to proceed or I can add this builder to @4a6f656c 's linux-riscv64-jsing's pool

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 26, 2021

@mengzhuo Excellent, let's proceed then, thank you again. CL 329489 is reviewed, can you address the remaining comment on it, and submit it? After that, I'll redeploy coordinator, which will allow the reverse builder to connect (I understand you have a builder key, but if not, I can provide it via your Gerrit email if you ask).

@dmitshur dmitshur added this to In Progress in Go Release Team Aug 26, 2021
@mengzhuo
Copy link
Contributor Author

@mengzhuo mengzhuo commented Aug 27, 2021

@dmitshur CL 329489 is broken and needs fixed, I will updated it today.
I don't have key for linux-riscv64-unmatched please send the key to me, thanks.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 27, 2021

@mengzhuo A key's been provided via email. Patch set 2 of CL 329489 looks good, please submit it when you're ready, and after the following cmd/coordinator deploy the reverse builder will be able to connect.

gopherbot pushed a commit to golang/build that referenced this issue Aug 27, 2021
This adds a reverse buildlet for linux riscv64 running under
Hifive Unmatched.

For golang/go#46804.

Change-Id: If5ed8b47205cecebcb90a4d1b03c463e1eb466c7
Reviewed-on: https://go-review.googlesource.com/c/build/+/329489
Trust: Meng Zhuo <mzh@golangcn.org>
Run-TryBot: Meng Zhuo <mzh@golangcn.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Sep 1, 2021

cmd/coordinator has been redeployed, so the reverse builder should be able to connect. It’s visible at https://farmer.golang.org now:

host-linux-riscv64-unmatched: 0/0 (1 missing)

@mengzhuo
Copy link
Contributor Author

@mengzhuo mengzhuo commented Sep 1, 2021

linux-riscv64-unmatched is up and running now. Thanks @dmitshur !

@mengzhuo mengzhuo closed this as completed Sep 1, 2021
Go Release Team automation moved this from In Progress to Done Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders NeedsFix new-builder
Projects
Development

No branches or pull requests

5 participants