-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: adding linux-riscv64-unmatched builder #46804
Comments
/cc @golang/release |
Change https://golang.org/cl/329489 mentions this issue: |
It would be good to understand what the plan is for (the other option would be to look at sharding the workloads, but that has its own sets of challenges) |
It's hard to have a concrete plan, since these builders are reverse and depend on people running them. Having multiple builders for the same platform can help if one goes missing, another can still provide coverage. Having them share workload would likely be better, but we don't have good support for that.
That seems reasonable to me. Also CC @bradfitz who's the owner of |
Running two might make sense, but I certainly doubt three is beneficial - even with one, if that disappears for a period of time, we can readily get a replacement online (especially now that the hardware is more readily available).
Sounds like a plan.
|
If this offer still stands @mengzhuo, I think we can proceed. Has a builder key already been provided, or does that need to happen? I can review CL 329489 this week. |
@mengzhuo Excellent, let's proceed then, thank you again. CL 329489 is reviewed, can you address the remaining comment on it, and submit it? After that, I'll redeploy coordinator, which will allow the reverse builder to connect (I understand you have a builder key, but if not, I can provide it via your Gerrit email if you ask). |
@dmitshur CL 329489 is broken and needs fixed, I will updated it today. |
This adds a reverse buildlet for linux riscv64 running under Hifive Unmatched. For golang/go#46804. Change-Id: If5ed8b47205cecebcb90a4d1b03c463e1eb466c7 Reviewed-on: https://go-review.googlesource.com/c/build/+/329489 Trust: Meng Zhuo <mzh@golangcn.org> Run-TryBot: Meng Zhuo <mzh@golangcn.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
cmd/coordinator has been redeployed, so the reverse builder should be able to connect. It’s visible at https://farmer.golang.org now:
|
linux-riscv64-unmatched is up and running now. Thanks @dmitshur ! |
According to #41956 and @cagedmantis suggestion.
I’m requesting builder
linux-riscv64-unmatched
The text was updated successfully, but these errors were encountered: