Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: unable to add a post submit builder for non-master branch #46864

Open
cagedmantis opened this issue Jun 21, 2021 · 2 comments

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jun 21, 2021

While troubleshooting #46786 we discovered an edge-case where a post submit was not initiated even thought the configuration seemed correct. @dmitshur discovered that the coordinator will not bootstrap post submit builds for builders which are not configured to run for the go repository in the master branch.

@golang/release

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jun 21, 2021

The second bullet point in #30779 is related to this.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 21, 2021

Change https://golang.org/cl/329929 mentions this issue: cmd/coordinator: enable post submit builder for linux-amd64-unified

Loading

gopherbot pushed a commit to golang/build that referenced this issue Jun 24, 2021
This change enables post submit builder runs for linux-amd64-unified
on the dev.typeparams branch. When the coordinator bootstraps new
builders, it omits builders which are not for the go repository and
the master branch.

Fixes golang/go#46786
Updates golang/go#46864

Change-Id: I4c74df8f02674e0265b455eee92983f2e6c41229
Reviewed-on: https://go-review.googlesource.com/c/build/+/329929
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur removed this from the Backlog milestone Jun 27, 2021
@dmitshur dmitshur added this to the Unreleased milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants