Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: MarshalAuthorizedKey discards comment #46870

Open
dpogorzelski opened this issue Jun 22, 2021 · 2 comments
Open

x/crypto/ssh: MarshalAuthorizedKey discards comment #46870

dpogorzelski opened this issue Jun 22, 2021 · 2 comments
Labels
NeedsInvestigation
Milestone

Comments

@dpogorzelski
Copy link

@dpogorzelski dpogorzelski commented Jun 22, 2021

What version of Go are you using (go version)?

1.16

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
GOHOSTARCH="amd64"
GOHOSTOS="darwin"

Hello, it seems like https://github.com/golang/crypto/blob/master/ssh/keys.go#L281 will never consider writing the comment of the key so when parsing such key later on via https://github.com/golang/crypto/blob/master/ssh/keys.go#L85 the comment value will always be empty.

@dpogorzelski
Copy link
Author

@dpogorzelski dpogorzelski commented Jun 22, 2021

Please also notice that the https://github.com/golang/crypto/blob/master/ssh/keys.go#L293 interface has a method to retrieve the key type but not the comment

@gopherbot gopherbot added this to the Unreleased milestone Jun 22, 2021
@toothrot toothrot added the NeedsInvestigation label Jun 22, 2021
@toothrot
Copy link
Contributor

@toothrot toothrot commented Jun 22, 2021

/cc @FiloSottile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

3 participants