As @bcmills points out in CL 330253, there is a bug in the package qualification logic of CL 313035. The nominal bug is the use of pkg rather than check.pkg on line 34 of errors.go, but I additionally noticed that our test coverage is not functioning as we expect: testdata error message extraction stops at the first ", so assertions in check tests that were checking that imports were qualified were not actually checking anything.
Opening this as a release blocker for tracking purposes. I'm fixing now.
The text was updated successfully, but these errors were encountered:
This is a partial port of https://golang.org/cl/330629, containing
only the actual bug fix and adjustements to another test file.
The respective test case has not been ported yet as it requires
some bigger adjustments.
Trust: Robert Griesemer <firstname.lastname@example.org>
Run-TryBot: Robert Griesemer <email@example.com>
Reviewed-by: Robert Findley <firstname.lastname@example.org>
TryBot-Result: Go Bot <email@example.com>