Repository navigation
x/sys: windows.WTD_STATEACTION_VERIFY has incorrect value #46906
Description
What version of Go are you using (go version)?
$ go version go version go1.16.5 windows/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env set GO111MODULE= set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\fedegc\AppData\Local\go-build set GOENV=C:\Users\fedegc\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOINSECURE= set GOMODCACHE=C:\Users\fedegc\go\pkg\mod set GONOPROXY= set GONOSUMDB= set GOOS=windows set GOPATH=C:\Users\fedegc\go set GOPRIVATE= set GOPROXY=https://proxy.golang.org,direct set GOROOT=C:\Program Files\Go set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64 set GOVCS= set GOVERSION=go1.16.5 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD=NUL set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\fedegc\AppData\Local\Temp\go-build2839842620=/tmp/go-build -gno-record-gcc-switches
What did you do?
What did you expect to see?
windows.WTD_STATEACTION_VERIFY value is 0x00000001 (according to msdn)
What did you see instead?
windows.WTD_STATEACTION_VERIFY value is 0x00000010 (types_windows.go)
Activity
[-]windows.WTD_STATEACTION_VERIFY wrong value[/-][+]x/sys: windows.WTD_STATEACTION_VERIFY wrong value[/+][-]x/sys: windows.WTD_STATEACTION_VERIFY wrong value[/-][+]x/sys: windows.WTD_STATEACTION_VERIFY has incorrect value[/+]toothrot commentedon Jun 24, 2021
@bufflig - this seems possibly a typo?
networkimprov commentedon Jun 25, 2021
cc @alexbrainman @mattn
alexbrainman commentedon Jun 27, 2021
I agree. It is a mistake in
https://go-review.googlesource.com/c/sys/+/285715
@konangc87 would you like to send a fix for your issue yourself? Here is
https://golang.org/doc/contribute
how to contribute.
/cc @zx2c4 because he authored the CL 285715.
Alex
zx2c4 commentedon Jun 27, 2021
Nice catch! Looks like a typo indeed? Or mingw headers are wrong? I'll have to check how this happened. I wonder, though, what the behavior of 0x10 is, as I've been using the bad code in question for some time.
I can send a CL for this if you don't want to.
gopherbot commentedon Jun 27, 2021
Change https://golang.org/cl/331010 mentions this issue:
windows: fix constant value of WTD_STATEACTION_VERIFYkonangc87 commentedon Jun 28, 2021
No problem. I'll submit the fix =)
zx2c4 commentedon Jun 28, 2021
https://golang.org/cl/331010 covers it already.
gopherbot commentedon Nov 17, 2021
Change https://golang.org/cl/364794 mentions this issue:
windows: skip TestWinVerifyTrustwindows: skip TestWinVerifyTrust
gopherbot commentedon Nov 23, 2021
Change https://golang.org/cl/366655 mentions this issue:
windows: re-eenable TestWinVerifyTrust with newly signed filegopherbot commentedon Nov 23, 2021
Change https://golang.org/cl/366655 mentions this issue:
windows: re-enable TestWinVerifyTrust with newly signed filewindows: re-enable TestWinVerifyTrust with newly signed file
windows: fix constant value of WTD_STATEACTION_VERIFY