-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys: windows.WTD_STATEACTION_VERIFY has incorrect value #46906
Comments
@bufflig - this seems possibly a typo? |
I agree. It is a mistake in https://go-review.googlesource.com/c/sys/+/285715 @konangc87 would you like to send a fix for your issue yourself? Here is https://golang.org/doc/contribute how to contribute. /cc @zx2c4 because he authored the CL 285715. Alex |
Nice catch! Looks like a typo indeed? Or mingw headers are wrong? I'll have to check how this happened. I wonder, though, what the behavior of 0x10 is, as I've been using the bad code in question for some time. I can send a CL for this if you don't want to. |
Change https://golang.org/cl/331010 mentions this issue: |
No problem. I'll submit the fix =) |
https://golang.org/cl/331010 covers it already. |
Change https://golang.org/cl/364794 mentions this issue: |
This test is failing (with different failure modes) on two different builders. Adding a skip until it can be made more robust. For golang/go#49651 For golang/go#49266 Updates golang/go#46906 Change-Id: I0fdd0e6f729c37e234b62b65abc53003eb8834f0 Reviewed-on: https://go-review.googlesource.com/c/sys/+/364794 Trust: Bryan C. Mills <bcmills@google.com> Trust: Patrik Nyblom <pnyb@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Patrik Nyblom <pnyb@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change https://golang.org/cl/366655 mentions this issue: |
Change https://golang.org/cl/366655 mentions this issue: |
Rather than disabling this test, let's just not make it rely on Microsoft files, whose signing validity period we can't depend on. Instead, we include our own EV-signed artifact, with a Digicert timestamp using a certificate valid for a decade. Fixes golang/go#49651. Fixes golang/go#49266. For golang/go#46906. Change-Id: Idadba346810017b8f769d6fac1ddd357d4dee93c Reviewed-on: https://go-review.googlesource.com/c/sys/+/366655 Trust: Jason A. Donenfeld <Jason@zx2c4.com> Trust: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Go Bot <gobot@golang.org>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
windows.WTD_STATEACTION_VERIFY value is 0x00000001 (according to msdn)
What did you see instead?
windows.WTD_STATEACTION_VERIFY value is 0x00000010 (types_windows.go)
The text was updated successfully, but these errors were encountered: