Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: progress report canceled and not marked as done #46930

Open
stamblerre opened this issue Jun 25, 2021 · 0 comments
Open

x/tools/gopls: progress report canceled and not marked as done #46930

stamblerre opened this issue Jun 25, 2021 · 0 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jun 25, 2021

In a test failure on https://golang.org/cl/330969, we got this log: https://storage.googleapis.com/go-build-log/37f9a8f6/linux-amd64-race_7069ae28.log.

Here are the relevant logs:

[Trace - 16:39:22.158 PM] Received request 'window/workDoneProgress/create - (14)'.
Params: {"token":"2673644565579601470"}


[Trace - 16:39:22.161 PM] Sending response 'window/workDoneProgress/create - (14)' in 3ms.
Result: 


[Trace - 16:39:22.163 PM] Received notification '$/cancelRequest'.
Params: {"id":14}

The token 2673644565579601470 never gets a Done. progress report, and it's listed as outstanding work when the test fails:

#### End Gopls Test Logs for "TestProgressBarErrors/singleton"
--- FAIL: TestProgressBarErrors (20.41s)
    --- FAIL: TestProgressBarErrors/singleton (20.00s)
        diagnostics_test.go:1539: waiting on:
            	Unmet: no outstanding work
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Error: "2021/06/25 16:39:21 copying workspace dir: /workd...
            	Info: "2021/06/25 16:39:21 go env for /workdir/tmp/gopls-...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=5...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=7...
            
            #### diagnostics:
            	go.mod (version 3):
            
            #### outstanding work:
            	!NO NAME(token: 2673644565579601470): 0.00
            #### completed work:
            	Error loading workspace: 1
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	diagnosing opened files: 1
            	diagnosing changed files: 2
            	diagnosing saved files: 2
            	diagnosing files changed on disk: 2
            	Load: 2
        runner.go:310: Shutdown: context deadline exceeded
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/diagnostics	269.024s
ok  	golang.org/x/tools/gopls/internal/regtest/misc	226.881s
ok  	golang.org/x/tools/gopls/internal/regtest/modfile	44.929s
ok  	golang.org/x/tools/gopls/internal/regtest/watch	52.971s
ok  	golang.org/x/tools/gopls/internal/regtest/workspace	86.820s
?   	golang.org/x/tools/gopls/release	[no test files]
ok  	golang.org/x/tools/gopls/test	115.662s
ok  	golang.org/x/tools/gopls/test/debug	24.212s
FAIL

/cc @findleyr

@gopherbot gopherbot added this to the Unreleased milestone Jun 25, 2021
@stamblerre stamblerre removed this from the Unreleased milestone Jun 26, 2021
@stamblerre stamblerre added this to the gopls/v0.7.1 milestone Jun 26, 2021
@stamblerre stamblerre removed this from the gopls/v0.7.1 milestone Jul 26, 2021
@stamblerre stamblerre added this to the gopls/v0.7.2 milestone Jul 26, 2021
@stamblerre stamblerre removed this from the gopls/v0.7.2 milestone Sep 9, 2021
@stamblerre stamblerre added this to the gopls/on-deck milestone Sep 9, 2021
@stamblerre stamblerre self-assigned this Sep 10, 2021
@stamblerre stamblerre removed their assignment Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants