Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: IWL progress report canceled and not marked as done #46930

Closed
stamblerre opened this issue Jun 25, 2021 · 7 comments
Closed

x/tools/gopls: IWL progress report canceled and not marked as done #46930

stamblerre opened this issue Jun 25, 2021 · 7 comments
Labels
gopls NeedsInvestigation okay-after-beta1 Testing Tools
Milestone

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Jun 25, 2021

In a test failure on https://golang.org/cl/330969, we got this log: https://storage.googleapis.com/go-build-log/37f9a8f6/linux-amd64-race_7069ae28.log.

Here are the relevant logs:

[Trace - 16:39:22.158 PM] Received request 'window/workDoneProgress/create - (14)'.
Params: {"token":"2673644565579601470"}


[Trace - 16:39:22.161 PM] Sending response 'window/workDoneProgress/create - (14)' in 3ms.
Result: 


[Trace - 16:39:22.163 PM] Received notification '$/cancelRequest'.
Params: {"id":14}

The token 2673644565579601470 never gets a Done. progress report, and it's listed as outstanding work when the test fails:

#### End Gopls Test Logs for "TestProgressBarErrors/singleton"
--- FAIL: TestProgressBarErrors (20.41s)
    --- FAIL: TestProgressBarErrors/singleton (20.00s)
        diagnostics_test.go:1539: waiting on:
            	Unmet: no outstanding work
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Error: "2021/06/25 16:39:21 copying workspace dir: /workd...
            	Info: "2021/06/25 16:39:21 go env for /workdir/tmp/gopls-...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=5...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=7...
            
            #### diagnostics:
            	go.mod (version 3):
            
            #### outstanding work:
            	!NO NAME(token: 2673644565579601470): 0.00
            #### completed work:
            	Error loading workspace: 1
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	diagnosing opened files: 1
            	diagnosing changed files: 2
            	diagnosing saved files: 2
            	diagnosing files changed on disk: 2
            	Load: 2
        runner.go:310: Shutdown: context deadline exceeded
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/diagnostics	269.024s
ok  	golang.org/x/tools/gopls/internal/regtest/misc	226.881s
ok  	golang.org/x/tools/gopls/internal/regtest/modfile	44.929s
ok  	golang.org/x/tools/gopls/internal/regtest/watch	52.971s
ok  	golang.org/x/tools/gopls/internal/regtest/workspace	86.820s
?   	golang.org/x/tools/gopls/release	[no test files]
ok  	golang.org/x/tools/gopls/test	115.662s
ok  	golang.org/x/tools/gopls/test/debug	24.212s
FAIL

/cc @findleyr

@gopherbot gopherbot added Tools gopls labels Jun 25, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jun 25, 2021
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.7.1 Jun 26, 2021
@stamblerre stamblerre modified the milestones: gopls/v0.7.1, gopls/v0.7.2 Jul 26, 2021
@stamblerre stamblerre modified the milestones: gopls/v0.7.2, gopls/on-deck Sep 9, 2021
@stamblerre stamblerre self-assigned this Sep 10, 2021
@stamblerre stamblerre removed their assignment Oct 19, 2021
@bcmills
Copy link
Member

bcmills commented Nov 2, 2021

This test has a high error rate, and it runs on TryBots (https://storage.googleapis.com/go-build-log/30a82efc/linux-amd64-race_29baf629.log). To me, that makes it a release-blocker via #11811.

greplogs --dashboard -md -l -e 'FAIL: TestProgressBarErrors'

2021-11-02T16:19:52-058ed05-58fb05a/linux-amd64-race
2021-11-02T15:54:27-058ed05-631b567/linux-386-buster
2021-11-02T15:33:01-4d06874-da7173a/linux-amd64-race
2021-11-01T19:56:50-ee08195-d19c5bd/linux-amd64-race
2021-11-01T18:01:07-e8bb373-d19c5bd/linux-amd64-race
2021-11-01T13:50:47-513e3fb-4a84298/linux-amd64-race
2021-10-30T00:47:26-a6c6f4b-d19c5bd/linux-amd64-race
2021-10-30T00:47:26-a6c6f4b-5d6d9f5/netbsd-386-9_0
2021-10-29T22:29:31-a2be0cd-c812b97/linux-riscv64-unmatched
2021-10-29T21:19:39-a2be0cd-4a84298/windows-amd64-race
2021-10-29T17:12:47-d6a9af8-3aecb3a/linux-amd64-race
2021-10-29T00:04:41-d6a9af8-af05d8b/linux-amd64-race
2021-10-28T20:43:39-e7eb6f6-b954024/android-amd64-emu
2021-10-28T18:01:34-c8ad2e1-18b9702/android-386-emu
2021-10-28T03:35:34-8de2a7f-b8f928b/linux-amd64-race
2021-10-28T02:36:02-8de2a7f-1a6281d/linux-amd64-race
2021-10-27T19:33:07-1b02aa2-514ebae/android-386-emu
2021-10-27T19:33:07-1b02aa2-11b64b4/linux-amd64-race
2021-10-27T02:41:01-e1e2965-13eccaa/windows-amd64-2016
2021-10-26T19:04:53-9626607-1dc77a3/linux-amd64-race
2021-10-25T20:08:25-fc8b4ca-252324e/android-amd64-emu
2021-10-23T16:17:58-affba50-3cd28ba/dragonfly-amd64
2021-10-21T20:12:09-baf4e38-5a3d0f5/dragonfly-amd64
2021-10-18T15:54:41-98f6e03-c091767/android-amd64-emu
2021-10-16T16:27:40-98f6e03-640a49b/linux-amd64-race
2021-10-15T21:46:06-98f6e03-ed1c8db/android-amd64-emu
2021-10-15T14:09:01-98f6e03-c580180/android-amd64-emu
2021-10-15T03:49:17-288d0b3-8dab959/android-amd64-emu
2021-10-14T12:38:31-88e80df-c580180/linux-amd64-race
2021-10-13T04:56:02-378b9e1-c580180/linux-arm64-packet
2021-10-12T19:23:00-0b930fb-2ac3bdf/android-386-emu
2021-10-12T06:55:50-c83725b-d887d3b/linux-riscv64-unmatched
2021-10-07T14:37:45-d477ef3-ebeab63/android-386-emu
2021-10-02T00:44:24-0ebff1a-afe43f1/linux-riscv64-unmatched
2021-10-01T21:26:43-0ebff1a-7d57324/linux-amd64-race
2021-09-29T16:42:30-d42c92b-c2de759/android-386-emu
2021-09-28T20:12:24-b182fde-7d57324/android-386-emu
2021-09-28T17:50:53-ba6b94c-8cf0a08/windows-amd64-2016
2021-09-27T21:53:31-ba6b94c-7887313/android-amd64-emu
2021-09-27T18:14:10-ba6b94c-ecac351/android-386-emu
2021-09-24T21:18:44-ba6b94c-7d57324/android-386-emu
2021-09-24T19:46:09-939195f-cfd0868/linux-riscv64-unmatched
2021-09-24T00:30:36-6d1e33f-c90ead9/android-386-emu
2021-09-22T22:55:16-c8db761-1319b14/android-386-emu
2021-09-21T20:35:14-b98090b-552410f/linux-ppc64le-power9osu
2021-09-21T03:32:29-fe076c8-abc4f09/android-386-emu
2021-09-21T02:24:06-91c880c-986f8ea/linux-riscv64-unmatched
2021-09-20T19:55:18-d2417d5-552410f/linux-amd64-race
2021-09-20T15:08:51-a0016a2-552410f/android-386-emu
2021-09-17T23:21:29-2758b04-f01721e/android-amd64-emu
2021-09-17T22:19:21-2758b04-3fa35b5/android-amd64-emu
2021-09-17T17:58:44-2758b04-552410f/android-amd64-emu
2021-09-17T16:17:54-aba0c5f-abc4f09/linux-amd64-race
2021-09-15T14:17:48-4ba3eff-5b48fca/android-386-emu
2021-09-15T14:06:14-4ba3eff-e4dfd78/linux-riscv64-unmatched
2021-09-15T09:43:47-02e5238-e4dfd78/linux-riscv64-unmatched
2021-09-15T09:43:47-02e5238-21a4e67/linux-amd64-race
2021-09-15T09:43:47-02e5238-170a72e/android-amd64-emu
2021-09-14T22:36:57-9207707-170a72e/linux-amd64-race
2021-09-14T21:57:30-258ee27-b2c04f0/android-386-emu
2021-09-14T00:08:19-384e5da-170a72e/linux-amd64-race
2021-09-13T21:01:54-e7de652-21a4e67/android-amd64-emu
2021-09-13T21:01:54-e7de652-170a72e/linux-amd64-race
2021-09-13T20:42:44-915f620-81a4fe6/linux-amd64-race
2021-09-10T16:08:21-295a39b-da1aa65/linux-amd64-race
2021-09-10T02:44:36-295a39b-2091bd3/linux-amd64-race
2021-09-09T19:43:39-c163c31-2c4f389/linux-amd64-race
2021-09-09T17:02:45-c163c31-f9271e4/linux-amd64-race
2021-09-08T16:19:36-e5f719f-409434d/android-amd64-emu
2021-08-31T21:26:33-70fb962-bb0b511/android-amd64-emu
2021-08-31T17:42:36-70fb962-ec51703/android-386-emu
2021-08-24T00:01:29-d4cc65f-8eeb1bf/android-386-emu
2021-08-18T17:22:40-bf6c7f2-ec51703/linux-amd64-race
2021-08-17T17:01:38-e32504c-ec51703/android-386-emu
2021-08-16T20:51:50-10bcabd-ec51703/android-386-emu
2021-08-13T03:36:45-8fae06a-d66b211/dragonfly-amd64
2021-08-13T03:35:06-3fce476-acbe242/android-386-emu
2021-08-06T16:51:12-f367f01-70546f6/linux-amd64-race
2021-08-04T17:02:12-f68a40b-6e73886/android-386-emu
2021-08-02T21:22:11-3395cb0-accf363/linux-ppc64le-buildlet
2021-07-26T22:15:24-07bc1bf-bfbb288/android-386-emu
2021-07-26T21:34:18-07bc1bf-9c81fd5/dragonfly-amd64
2021-07-26T20:19:17-4ad98e9-c6d89db/android-386-emu
2021-07-21T23:55:41-412ee17-3e48c03/linux-ppc64-buildlet
2021-07-12T22:00:43-de44776-bc51e93/linux-ppc64le-buildlet
2021-07-12T19:45:05-a7dfe3d-bc51e93/android-386-emu
2021-07-12T16:16:36-980829d-ab4085c/android-386-emu
2021-07-08T23:16:08-6994825-296ddf2/linux-amd64-race
2021-07-08T21:10:20-e688b94-296ddf2/linux-amd64-race
2021-07-08T19:56:07-71eae3a-fb052db/linux-ppc64-buildlet
2021-07-08T16:22:39-55cd480-2ca44fe/dragonfly-amd64
2021-07-08T02:47:23-640c1de-b51bf4f/linux-amd64-race
2021-07-07T20:06:16-fd00574-cb4cd9e/linux-amd64-race
2021-07-01T18:35:33-20dafe5-877688c/dragonfly-amd64
2021-06-30T18:03:06-f0847e0-c080d03/android-amd64-emu
2021-06-29T16:57:13-100b229-3463852/android-amd64-emu
2021-06-29T14:11:33-100b229-0e7012e/linux-amd64-race
2021-06-25T19:21:17-fe2294a-fd129a6/linux-ppc64-buildlet
2021-06-25T15:37:24-636017e-37f9a8f/dragonfly-amd64
2021-06-24T03:06:00-bfc1674-0e7012e/android-amd64-emu
2021-06-24T00:39:41-d824a74-73496e0/linux-amd64-race
2021-06-22T16:07:17-4c651fc-5bd09e5/dragonfly-amd64
2021-06-22T14:07:22-d25f906-666315b/netbsd-arm64-bsiegert
2021-06-22T02:37:43-d25f906-9afd158/dragonfly-amd64
2021-06-17T21:58:54-463a76b-45f251a/android-386-emu
2021-06-17T14:53:37-463a76b-4dede02/linux-ppc64-buildlet
2021-06-17T04:32:50-463a76b-97cee43/android-386-emu
2021-06-16T01:55:16-463a76b-7677616/android-386-emu
2021-06-14T19:26:24-4b484fb-d4f34f8/dragonfly-amd64
2021-06-08T16:06:52-4e58f8f-7677616/dragonfly-amd64
2021-06-05T19:52:26-1225b6f-e1fa260/dragonfly-amd64
2021-06-03T19:38:56-8f2cf6c-6d98301/dragonfly-amd64
2021-06-03T16:41:39-4abb1e2-0d6115c/dragonfly-amd64
2021-05-28T03:34:02-5ab822f-3de3440/dragonfly-amd64

@bcmills bcmills added NeedsInvestigation okay-after-beta1 release-blocker labels Nov 2, 2021
@bcmills bcmills modified the milestones: gopls/on-deck, Go1.18 Nov 2, 2021
@findleyr findleyr self-assigned this Nov 2, 2021
@bcmills
Copy link
Member

bcmills commented Nov 2, 2021

@findleyr
Copy link
Contributor

findleyr commented Nov 2, 2021

Indeed. I'll fix or delete.

@gopherbot
Copy link

gopherbot commented Nov 3, 2021

Change https://golang.org/cl/361156 mentions this issue: internal/regtest: skip TestProgressBarErrors: it is too flaky

gopherbot pushed a commit to golang/tools that referenced this issue Nov 3, 2021
Updates golang/go#46930

Change-Id: I7bfaccf6b632623218450532e82cbd0ff45f49b7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/361156
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@findleyr
Copy link
Contributor

findleyr commented Nov 5, 2021

Similar to #48773, this is still a bug, but no longer a release blocker now that the test is skipped :-/

@findleyr findleyr modified the milestones: gopls/v0.8.0, gopls/v0.8.1 Feb 21, 2022
@findleyr findleyr modified the milestones: gopls/v0.8.1, gopls/v0.8.2 Mar 7, 2022
@findleyr findleyr modified the milestones: gopls/v0.8.2, gopls/on-deck Mar 24, 2022
@findleyr findleyr added Testing and removed gopls/testing labels May 10, 2022
@findleyr findleyr modified the milestones: gopls/later, gopls/v0.9.0 May 18, 2022
@findleyr
Copy link
Contributor

findleyr commented May 18, 2022

Per #50885, I think there's a real user-facing issue here, not just a test flake. We should carefully investigate how a dangling IWL progress report is possible.

@findleyr findleyr changed the title x/tools/gopls: progress report canceled and not marked as done x/tools/gopls: IWL progress report canceled and not marked as done May 18, 2022
@gopherbot
Copy link

gopherbot commented Jun 1, 2022

Change https://go.dev/cl/409936 mentions this issue: internal/lsp/progress: detach context for all progress notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls NeedsInvestigation okay-after-beta1 Testing Tools
Projects
None yet
Development

No branches or pull requests

4 participants