Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html/template: data race with concurrent ExecuteTemplate calls [1.15 backport] #47041

Open
gopherbot opened this issue Jul 2, 2021 · 4 comments
Open

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 2, 2021

@josharian requested issue #47040 to be considered for backport to the next 1.15 minor release.

496d7c6 is the fix.

@gopherbot, please open backport issues.

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Jul 7, 2021

Data race in what is documented to be a concurrent-safe context with no workaround. Approved.

@josharian
Copy link
Contributor

@josharian josharian commented Jul 12, 2021

Thanks, @mknyszek.

@ianlancetaylor as the original author of the fix, I think the next step is for you to mail a cherry-pick change. Ditto for #47042.

@dmitshur dmitshur removed this from the Go1.15.14 milestone Jul 12, 2021
@dmitshur dmitshur added this to the Go1.15.15 milestone Jul 12, 2021
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jul 13, 2021

I have twice had to revert CLs that fix this problem. The current CL has not yet been in any release, so it may just be pending another revert. I think it would be very premature to backport the CL to the 1.15 and 1.16 branches before the 1.17 release is out.

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Jul 13, 2021

@ianlancetaylor Sounds good, I'll un-approve then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants