Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: flag exclude and replace in go.mod #47094

Open
colin-sitehost opened this issue Jul 8, 2021 · 0 comments
Open

x/pkgsite: flag exclude and replace in go.mod #47094

colin-sitehost opened this issue Jul 8, 2021 · 0 comments

Comments

@colin-sitehost
Copy link

@colin-sitehost colin-sitehost commented Jul 8, 2021

currently, there is a listing for "Valid go.mod file" in the "Details" section. it makes sense that this is more of a presence/absence and syntax check, but I was caught off guard when I could not go-get something reported as "Valid":

go get: github.com/path/to/want@none updating to
	github.com/path/to/want@v1.0.0 requires
	github.com/path/to/dep@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

it turned out that this module had an require version and replaced it with the local file system. both replace and exclude are intended for local development and temporary workarounds, see #37559, thus it seems reasonable to flag such modules. it is possible to craft a go.mod with exclude or replace directives that also works with go-get, but considering it behaves differently as a main and dependent module, it still seems worth flagging.

@gopherbot gopherbot added this to the Unreleased milestone Jul 8, 2021
@jamalc jamalc removed this from the Unreleased milestone Jul 12, 2021
@jamalc jamalc added this to the pkgsite/unplanned milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants