Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: LookupSRV doesn't validate record names are consistent #47110

Open
rolandshoemaker opened this issue Jul 9, 2021 · 0 comments
Open

net: LookupSRV doesn't validate record names are consistent #47110

rolandshoemaker opened this issue Jul 9, 2021 · 0 comments
Milestone

Comments

@rolandshoemaker
Copy link
Member

@rolandshoemaker rolandshoemaker commented Jul 9, 2021

LookupSRV returns the 'canonical name' alongside the slice of SRV records, which is typically used to determine whether the name that was passed to LookupSRV was CNAME'd to another name. The returned canonical name is extracted from the first returned record header NAME, but it is not verified that the rest of the records are consistent.

If a resolver returns a response containing records with various names, LookupSRV obscures this by returning just the first name. Ideally it should verify that all of the names are consistent, returning an error if there were multiple names returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant