Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: pageless search #47315

Open
jba opened this issue Jul 21, 2021 · 7 comments
Open

x/pkgsite: pageless search #47315

jba opened this issue Jul 21, 2021 · 7 comments

Comments

@jba
Copy link
Contributor

@jba jba commented Jul 21, 2021

Our data shows that people seldom look past the first page, and almost never past the first three pages. To simplify both the user experience and the logic, we're going to do away with paginating search. Instead, we will show the top 10 results by default, and users can select more results from a dropdown.

@jba jba added this to the pkgsite/unplanned milestone Jul 21, 2021
@jba jba self-assigned this Jul 21, 2021
@cespare
Copy link
Contributor

@cespare cespare commented Jul 21, 2021

What does "select more results from a dropdown" mean, if there are no pages?

@julieqiu julieqiu removed this from the pkgsite/unplanned milestone Jul 21, 2021
@julieqiu julieqiu added this to the pkgsite/search milestone Jul 21, 2021
@fzipp
Copy link
Contributor

@fzipp fzipp commented Jul 21, 2021

@cespare Probably like the "More results" button below Google search results on mobile.

@jba
Copy link
Contributor Author

@jba jba commented Jul 21, 2021

You won't be able to get more results indefinitely, though. You'll have a choice of, say, 10, 30 or 100 results.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 23, 2021

Change https://golang.org/cl/336770 mentions this issue: internal/frontend: don't paginate for grouped search

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jul 23, 2021
When the search-grouping experiment is on, don't paginate the
results. Instead present all of them, and let the user choose how many
they want from a fixed list.

For golang/go#47315

Change-Id: Ia7639f619bf1cce62067c69983f946d964161b17
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/336770
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
@pwaller
Copy link
Contributor

@pwaller pwaller commented Aug 18, 2021

Why stop at 100?

I'm disappointed when I came to go.dev after a hiatus that I don't get the full list of packages like the good old days on godoc.org. Sometimes you search for something and get a lot of hits -- when that happens it can be useful to be able to press ctrl-f in your browser to jump through them to look for something specific.

Is there any good reason to paginate vs show everything? What is the most extreme case of number of results and what detriment is there to showing them all? My recollection was skimming through hundreds or even thousands of packages and finding what I was looking for that way with the scroll bar. Like glancing at a bookshelf -- serendipitously discovering things.

@jba
Copy link
Contributor Author

@jba jba commented Aug 18, 2021

Our data shows that very few people went past the tenth page. We added a limit for reliability reasons.

@changkun
Copy link
Contributor

@changkun changkun commented Aug 20, 2021

I think that very few people went past the tenth page because there are no more interesting results and a lot of duplications of forked packages. The pkg.go.dev should improve the search results instead of removing pagination.

If we want to discover what's out there, the pkg.go.dev search page says too little until we click the page. In the worst case, we still have to go to the package repository to see why it receives a high ranking.

Comparing to GitHub's search page, pkg.go.dev shows only 100 results removes the discovery functionality completely. (The whole Go world is not dominant by packages who being imported the most, diversity is also important)

See a comparison:

For instance, the second (a fork of the first) and the third results (an internal package) in pkg.go.dev is completely useless. The fourth result -- completely irrelevant. Comparing to what's showed on GitHub, one see differences.

@julieqiu julieqiu removed this from the pkgsite/search milestone Sep 13, 2021
@julieqiu julieqiu added this to the pkgsite/2021 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants