Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text: running go generate fails in TestParseScript #47566

Open
josharian opened this issue Aug 5, 2021 · 2 comments
Open

x/text: running go generate fails in TestParseScript #47566

josharian opened this issue Aug 5, 2021 · 2 comments
Labels
NeedsFix
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Aug 5, 2021

$ go version
go version devel go1.17-fd45e267c2 Thu Aug 5 20:22:31 2021 +0000 darwin/arm64
$ git rev-parse master
3115f89c4b99a620c7f1a4395a2b4405e95b82b6
$ go generate
?   	golang.org/x/text/encoding/internal/identifier	[no test files]
ok  	golang.org/x/text/unicode/cldr	(cached)
ok  	golang.org/x/text/unicode/runenames	(cached)
ok  	golang.org/x/text/width	(cached)
ok  	golang.org/x/text/unicode/rangetable	(cached)
ok  	golang.org/x/text/unicode/norm	(cached)
ok  	golang.org/x/text/unicode/bidi	(cached)
ok  	golang.org/x/text/internal/export/idna	(cached)
--- FAIL: ./internal/language:
	--- FAIL: TestParseScript (0.00s)
	    language_test.go:153: 1:zzzz: was Afak, true; want Zzzz, true
	    language_test.go:153: 2:zyyy: was Adlm, true; want Zyyy, true
	FAIL
	FAIL	golang.org/x/text/internal/language	0.092s
	FAIL
	Error: exit status 1
--- ABORT: ./internal/language/compact
--- ABORT: ./language
--- ABORT: ./collate
--- ABORT: ./internal/number
--- ABORT: ./currency
--- ABORT: ./internal
--- ABORT: ./internal/cldrtree
--- ABORT: ./encoding/htmlindex
--- ABORT: ./encoding/ianaindex
--- ABORT: ./date
--- ABORT: ./language/display
--- ABORT: ./cases
--- ABORT: ./secure/precis
--- ABORT: ./search
--- ABORT: ./feature/plural
FAIL
exit status 1
doc.go:5: running "go": exit status 1
go generate 37.59s user 7.72s system 159% cpu 28.492 total 975840 maxrss

cc @mpvl

@gopherbot gopherbot added this to the Unreleased milestone Aug 5, 2021
@josharian
Copy link
Contributor Author

@josharian josharian commented Aug 5, 2021

Looks like this is because we have type Script uint8 and there are now 258 scripts, so we overflow.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 5, 2021

Change https://golang.org/cl/340309 mentions this issue: internal/language: make Script a uint16

@seankhliao seankhliao added the NeedsFix label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix
Projects
None yet
Development

No branches or pull requests

3 participants