Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: runtime: add GOEXE #47567

Closed
codefromthecrypt opened this issue Aug 5, 2021 · 4 comments
Closed

proposal: runtime: add GOEXE #47567

codefromthecrypt opened this issue Aug 5, 2021 · 4 comments
Labels
Projects
Milestone

Comments

@codefromthecrypt
Copy link

@codefromthecrypt codefromthecrypt commented Aug 5, 2021

Is your feature request related to a problem? Please describe.

cross-platform go code has the same concerns as the "GOEXE" variable, effectively you want to append ".exe" if windows.

Describe the solution you'd like

runtime.GOEXE which acts the same as "GOEXE" except it is a constant, so that windows binaries will know to look for .exe when launching commands.

Describe alternatives you've considered

Currently, we define moreos.EXE for this, using a constant based on the OS.

@gopherbot gopherbot added this to the Proposal milestone Aug 5, 2021
@ianlancetaylor ianlancetaylor changed the title proposal: add runtime.GOEXE proposal: runtime: add GOEXE Aug 6, 2021
@ianlancetaylor ianlancetaylor added this to Incoming in Proposals Aug 6, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Aug 11, 2021

This seems a bit too trivial to be worth new API.

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Aug 11, 2021

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Loading

@rsc rsc moved this from Incoming to Active in Proposals Aug 11, 2021
@rsc rsc moved this from Active to Likely Decline in Proposals Aug 18, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Aug 18, 2021

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

Loading

@rsc rsc moved this from Likely Decline to Declined in Proposals Aug 25, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Aug 25, 2021

No change in consensus, so declined.
— rsc for the proposal review group

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Proposals
Declined
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants