Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/dl: include darwin-arm64 in the "Featured downloads" section #47578

Open
hyangah opened this issue Aug 6, 2021 · 3 comments
Open

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Aug 6, 2021

As more users start to use arm64, I think highlighting them in the Featured downloads section could help users pick the right version. Currently it shows only darwin-amd64 installer for Apple macOS.

Screen Shot 2021-08-06 at 12 54 40 PM

Or, is there any way to detect user's platform and use it to suggest the right one first?
Or is there any way to build a universal installer?

@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Aug 6, 2021

I believe the install page detects the OS https://golang.org/doc/install

Loading

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Aug 6, 2021

I believe the install page detects the OS https://golang.org/doc/install

Tried on an M1 machine with https://golang.org/doc/install but it shows the darwin-amd64 one instead of darwin-arm64. Maybe it only detects the OS, not the architecture?

Loading

@dmitshur dmitshur changed the title dl: include darwin-arm64 in the "Featured downloads" section x/website/internal/dl: include darwin-arm64 in the "Featured downloads" section Aug 6, 2021
@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2021
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 6, 2021

The darwin/arm64 installer download is currently considered "highlighted", so it shows up in bold:

image

(It was made "highlighted" when Go 1.16 came out in CL 278787.)

But not yet "featured", so it doesn't show up as a dedicated box at the top. Given darwin/arm64 port is a first-class port, and a good amount of time has passed that M1 devices are more widely used, perhaps now is a good time to do so.

Or, is there any way to detect user's platform and use it to suggest the right one first?

To my knowledge, likely out of device fingerprinting concerns, browsers don't officially expose the underlying system architecture, so web pages typically look the same regardless of whether the user is visiting from a macOS device with an Intel or Apple CPU.

I'm aware there are some workarounds, like getting the device GPU vendor name and checking for a known substring that M1 devices have. An example of that being used is the VLC home page, https://www.videolan.org/, which changes its default download link using that heuristic.

So, I'm not sure that we should try to add automatic detection. If we make both downloads Featured, they should be equally visible and hopefully easier to pick the intended one.

Or is there any way to build a universal installer?

This is possible too, but there are some trade-offs. We've considered it around 1.16 release but haven't decided to explore it further yet. It's a big enough change that it should probably be a separate issue.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants