Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: TestSysctlClockinfo failing with "input/output error" on openbsd-arm*-jsing since Aug. 2 #47629

Open
bcmills opened this issue Aug 10, 2021 · 4 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Aug 10, 2021

--- FAIL: TestSysctlClockinfo (0.00s)
    syscall_bsd_test.go:73: input/output error
FAIL
FAIL	golang.org/x/sys/unix	2.351s
$ greplogs --dashboard -md -l -e FAIL: TestSysctlClockinfo

2021-08-09T22:24:54-d867a43/1f9c9d8/openbsd-arm-jsing
2021-08-09T22:24:54-d867a43/1f9c9d8/openbsd-arm64-jsing
2021-08-09T22:24:54-d867a43/f1dce31/openbsd-arm-jsing
2021-08-09T22:24:54-d867a43/f1dce31/openbsd-arm64-jsing
2021-08-09T22:13:28-b450225/f1dce31/openbsd-arm-jsing
2021-08-09T22:13:28-b450225/f1dce31/openbsd-arm64-jsing
2021-08-09T20:39:39-8946682/f1dce31/openbsd-arm-jsing
2021-08-09T20:39:39-8946682/f1dce31/openbsd-arm64-jsing
2021-08-06T18:45:41-e5e7981/507cc34/openbsd-arm-jsing
2021-08-06T18:45:41-e5e7981/507cc34/openbsd-arm64-jsing
2021-08-06T18:45:41-e5e7981/63b968f/openbsd-arm64-jsing
2021-08-06T18:45:41-e5e7981/70546f6/openbsd-arm64-jsing
2021-08-06T18:45:41-e5e7981/7aeaad5/openbsd-arm64-jsing
2021-08-06T18:45:41-e5e7981/891547e/openbsd-arm-jsing
2021-08-06T18:45:41-e5e7981/891547e/openbsd-arm64-jsing
2021-08-06T18:45:41-e5e7981/f1dce31/openbsd-arm-jsing
2021-08-06T18:45:41-e5e7981/f1dce31/openbsd-arm64-jsing
2021-06-30T00:52:30-0f9fa26/6e73886/openbsd-arm-jsing
2021-06-30T00:52:30-0f9fa26/6e73886/openbsd-arm64-jsing
2021-06-30T00:52:30-0f9fa26/8a7ee4c/openbsd-arm-jsing
2021-06-30T00:52:30-0f9fa26/8a7ee4c/openbsd-arm64-jsing
2021-06-30T00:52:30-0f9fa26/fd45e26/openbsd-arm-jsing
2021-06-30T00:52:30-0f9fa26/fd45e26/openbsd-arm64-jsing

The last successful run on these builders was at Go commit f9d5095, which was merged June 29, and the first failure was at Go commit 8a7ee4c (Aug. 2). I'm not sure why the dashboard seems to be missing x/sys logs for all of July (CC @golang/release), but that at least gives a range to bisect.

@4a6f656c, any idea what's up with these failures?

@bcmills
Copy link
Member Author

@bcmills bcmills commented Oct 1, 2021

This test is still failing consistently. If there is some reason it cannot be fixed, it should be skipped.

Note that https://golang.org/wiki/PortingPolicy requires that “[a]t least one developer must be named (and agree) to maintain the port, by making required updates in a timely manner as architecture or operating system requirements change.” If no one is actively maintaining this port, it should be removed.

@bcmills bcmills removed this from the Unreleased milestone Oct 1, 2021
@bcmills bcmills added this to the Go1.18 milestone Oct 1, 2021
@bcmills
Copy link
Member Author

@bcmills bcmills commented Oct 1, 2021

This is a release-blocker for Go 1.18 via #11811. It may be resolved by fixing the broken functionality, adding a skip to the test on the affected platform(s), or removing these builders entirely (and dropping support for any ports that become untested as a result).

@heschi
Copy link
Contributor

@heschi heschi commented Oct 6, 2021

ping @4a6f656c

@4a6f656c
Copy link
Contributor

@4a6f656c 4a6f656c commented Oct 16, 2021

(cc @tklauser)

The struct clockinfo changed in the OpenBSD 6.9 release, hence the Clockinfo and SizeofClockinfo in unix/ztypes_openbsd_*.go no longer match up. This would have become visible on the openbsd/arm and openbsd/arm64 builders when they were upgraded to OpenBSD 6.9. Unfortunately, since none of the OpenBSD 386 or amd64 builders are running 6.9 (or now 7.0), it is not visible there.

The easy fix is to regenerate the definitions on a supported release - however, this will obviously mean that it will stop working on 6.8 and earlier (which are no longer supported releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants