Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: set the proper export version number before Go 1.18 #47654

Open
danscales opened this issue Aug 11, 2021 · 2 comments
Open

cmd/compile: set the proper export version number before Go 1.18 #47654

danscales opened this issue Aug 11, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@danscales
Copy link

@danscales danscales commented Aug 11, 2021

When we get closer to the beta for 1.18, we need to set the export version number to its new value,
iexportVersionGenerics = 3.

We are temporarily setting the export version back to 2 (in dev.typeparams, soon to be merged to master) for ease of internal testing, especially given a lot of x/tools and third-party tools that will break on the new export version.

@danscales danscales added this to the Go1.18 milestone Aug 11, 2021
@danscales danscales self-assigned this Aug 11, 2021
@danscales
Copy link
Author

@danscales danscales commented Aug 11, 2021

https://go-review.googlesource.com/c/go/+/341211 is the change the needs to be mostly reverted to fix this issue.

gopherbot pushed a commit that referenced this issue Aug 11, 2021
This is a temporary change. We will revert this back before the 1.18
release. We make this change now to simplify testing, since a lot of
tools will break on the new export version.

Updates #47654.

Change-Id: I0650fa753bb11229c71254d779dd61b5c1af9cdf
Reviewed-on: https://go-review.googlesource.com/c/go/+/341211
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 11, 2021

Change https://golang.org/cl/341211 mentions this issue: [dev.typeparams] cmd/compile: change export version to 1.17 for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants