Skip to content

x/net/http2: server sends RST_STREAM w/ PROTOCOL_ERROR to clients it incorrectly believes have violated max advertised num streams [1.17 backport] #47692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 13, 2021 · 4 comments · Fixed by Unity-and-wireless-communications/net#2
Closed

x/net/http2: server sends RST_STREAM w/ PROTOCOL_ERROR to clients it incorrectly believes have violated max advertised num streams [1.17 backport] #47692

gopherbot opened this issue Aug 13, 2021 · 4 comments · Fixed by Unity-and-wireless-communications/net#2
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.1

Comments

@gopherbot
Copy link
Contributor

@neild requested issue #42777 to be considered for backport to the next 1.17 minor release.

@gopherbot please open backport issues for 1.16 and 1.17.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 13, 2021
@gopherbot gopherbot mentioned this issue Aug 13, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.1 milestone Aug 16, 2021
@mknyszek
Copy link
Contributor

No workaround, notable HTTP bug.

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Aug 18, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 18, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/346890 mentions this issue: [internal-branch.go1.17-vendor] http2: complete outstanding async write before reading the next frame

gopherbot pushed a commit to golang/net that referenced this issue Sep 1, 2021
@fraenkel @cagedmantis
[internal-branch.go1.17-vendor] http2: complete outstanding async wri…
6d2eada 
…te before reading the next frame

Updates golang/go#42777
Fixes golang/go#47692

Change-Id: I8d7e35ded3fe508f6c285e84ba768104c3406bdf
Reviewed-on: https://go-review.googlesource.com/c/net/+/330909
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 60bc85c)
Reviewed-on: https://go-review.googlesource.com/c/net/+/346890
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/347009 mentions this issue: [release-branch.go1.17] all: update golang.org/x/net to latest

gopherbot pushed a commit that referenced this issue Sep 1, 2021
@neild @cherrymui
[release-branch.go1.17] all: update golang.org/x/net to pull in CL 34…
fcce86c 
…6890

For #47692.

Change-Id: I40d5a3ed245b99de5e82e336f955c60b58880cdb
Reviewed-on: https://go-review.googlesource.com/c/go/+/347009
Trust: Damien Neil <dneil@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging fcce86c to release-branch.go1.17.

fedosgad pushed a commit to fedosgad/oohttp that referenced this issue Jun 22, 2022
@fraenkel @cagedmantis
[internal-branch.go1.17-vendor] http2: complete outstanding async wri…
eae6a56 
…te before reading the next frame

Updates golang/go#42777
Fixes golang/go#47692

Change-Id: I8d7e35ded3fe508f6c285e84ba768104c3406bdf
Reviewed-on: https://go-review.googlesource.com/c/net/+/330909
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 60bc85c4be6d32924bcfddb728394cb8713f2c78)
Reviewed-on: https://go-review.googlesource.com/c/net/+/346890
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.1
Development

Successfully merging a pull request may close this issue.

[internal-branch.go1.17-vendor] http2: complete outstanding async wri… AlexanderYastrebov/net
2 participants
@mknyszek @gopherbot