x/pkgsite: redirect semver tags with build metadata #47757

julieqiu · 2021-08-17T18:36:32Z

gopherbot · 2021-08-19T17:05:09Z

Change https://golang.org/cl/343649 mentions this issue: tests/e2e: add github.com/go/logr/zapr@v1.0.0+1

gopherbot · 2021-08-19T17:05:10Z

Change https://golang.org/cl/343631 mentions this issue: internal/frontend: fix redirects

The go command removes build metadata as part of version canonicalization. +incompatible is the only metadata that may remain, but that can't appear in the vcs tag itself. As a result, a path@version like https://pkg.go.dev/github.com/go-logr/zapr@v1.0.0+1 will resolve to https://pkg.go.dev/github.com/go-logr/zapr@v1.0.1-0.20210809170106-a3325063a237. See https://proxy.golang.org/github.com/go-logr/zapr/@v/v1.0.0+1.info pkg.go.dev now redirects appropriately. See https://groups.google.com/g/golang-dev/c/bduZuUdzM_o/m/lBX634unAQAJ for context. This fix also redirects other cases where the requested and resolved versions do not match. For example, github.com/dgrijalva/jwt-go@v3.2.0 will redirect to v3.2.0+incompatible. For golang/go#47757 Change-Id: I236fbb9e0ed8ef0b1c3928460c2908fcbd9c2033 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/343631 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>

gopherbot added the pkgsite label Aug 17, 2021

gopherbot added this to the Unreleased milestone Aug 17, 2021

julieqiu added the NeedsFix label Aug 17, 2021

julieqiu removed this from the Unreleased milestone Aug 17, 2021

julieqiu added this to the pkgsite/unplanned milestone Aug 17, 2021

julieqiu self-assigned this Aug 19, 2021

Comments