Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: no stmt flag set for two lines of code that do generate instructions #47793

Closed
aarzilli opened this issue Aug 18, 2021 · 2 comments
Closed
Assignees

Comments

@aarzilli
Copy link
Contributor

@aarzilli aarzilli commented Aug 18, 2021

$ go version
go version go1.17 linux/amd64

it also reproduces on 1.17 windows/amd64 and 1.16.

Reproduction steps:

  1. Compile the tests of package github.com/dolthub/dolt/go/libraries/doltcore/sqle with -gcflags='all=-N -l' (commit d2c3c987593fe82e0571ffd3fda09afd340b4634 will do this)
  2. See the pcln table generated for github.com/dolthub/dolt/go/libraries/doltcore/sqle.NewTestEngine
  3. Lines 120 and 121 have instructions generated but none of them have the stmt flag set

Originally reported as go-delve/delve#2664
cc @dr2chase

@dr2chase dr2chase self-assigned this Aug 18, 2021
@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented Aug 18, 2021

It happens in expand calls, not sure of the exact failure yet, other than the statement was hanging off an OpDereference.
To see for yourself:

git clone https://github.com/dolthub/dolt
cd dolt/go/libraries/doltcore/sqle
GOSSADIR=`pwd` GOSSAFUNC=NewTestEngine go test -c -gcflags=all='-N -l' .

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 24, 2021

Change https://golang.org/cl/344769 mentions this issue: cmd/compile: preserve statements better in expandCalls

Loading

@gopherbot gopherbot closed this in bcdc61d Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants