Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: incorrect type reported for comma-err C functions (manifests itself in IDEs) [1.17 backport] #47854

Closed
gopherbot opened this issue Aug 20, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

@griesemer requested issue #47777 to be considered for backport to the next 1.17 minor release.

@gopherbot please backport to 1.17. This is a regression.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 20, 2021
@gopherbot gopherbot added this to the Go1.17.1 milestone Aug 20, 2021
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Aug 25, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 25, 2021
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround, and a regression.

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/347149 mentions this issue: [release-branch.go1.17] go/types: don't override x.mode before using it

gopherbot pushed a commit that referenced this issue Sep 1, 2021
Changing the mode of x before using the old value is clearly wrong.
And x is not needed anymore afterward so besides being misplaced,
the assignment is not needed in the first place.

Tested manually as it's a bit complicated to set up a test.

Fixes #47854.

Change-Id: I06f1fa9443eb98009b4276f566d557fd52f1d6d3
Reviewed-on: https://go-review.googlesource.com/c/go/+/343809
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
(cherry picked from commit e17439e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/347149
Run-TryBot: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Trust: Robert Findley <rfindley@google.com>
Trust: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 36c1717 to release-branch.go1.17.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants