Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
While reading http.TimeoutHandler implementation I noticed that in current docs there's no mention that all writes in the response are buffered in memory before being flushed to the client.
Digging a bit in the git history, this was a clarification that was present on the original implementation.
The last change that touched the docs has a good summary of some back and forth in implementing Flusher, which docs changes made this original note be lost.
It feels to me that clarifying that all writes are buffered to memory is something worth adding again since that should be considered by users when wrapping handlers that might produce big writes.
The proposed new docs for that paragraph could be:
// TimeoutHandler buffers all Handler writes to memory.
// It supports the Pusher interface but does not support the Hijacker
// or Flusher interfaces.
If that sounds like a good idea, I can create a CL with this change.
The text was updated successfully, but these errors were encountered:
Sorry, something went wrong.
Change https://golang.org/cl/345795 mentions this issue: net/http: clarify TimeoutHandler buffer writes to memory
net/http: clarify TimeoutHandler buffer writes to memory
Successfully merging a pull request may close this issue.