Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Apache 2.0 License detected but package documentation is still hidden #48068

Closed
diegocarrion-wk opened this issue Aug 30, 2021 · 3 comments
Closed

x/pkgsite: Apache 2.0 License detected but package documentation is still hidden #48068

diegocarrion-wk opened this issue Aug 30, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/license Issues related to licenses on pkg.go.dev. See our license policy https://pkg.go.dev/license-policy pkgsite
Milestone
pkgsite/license

Comments

@diegocarrion-wk
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/Workiva/ssllabs-go@v0.1.4/v3

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36

Screenshot

Captura de Pantalla 2021-08-30 a la(s) 17 40 34

What did you do?

Our legal team requires that we add extra text at the bottom of our LICENSE file mentioning other repos used in the creation of the repository. In order to hopefully get pkg.go.dev to still show our documentation, we added a LICENSE.docs file with standard Apache 2.0 text only.
It appears that it does indeed detect an Apache 2.0 license along with an UNKOWN file.

What did you expect to see?

We were hoping that we would see our package documentation, due to the inclusion of a detectable license.

What did you see instead?

Package documentaion hidden message.
@gopherbot gopherbot added this to the Unreleased milestone Aug 30, 2021
@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 30, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/licenses Aug 30, 2021
@jamalc jamalc assigned jamalc and jba and unassigned jamalc Aug 30, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/347401 mentions this issue: internal/licenses: add exception for Workiva/ssllabs-go

@jba
Copy link
Contributor

jba commented Sep 3, 2021

This should be live by next Tuesday.

@jba
Copy link
Contributor

jba commented Sep 9, 2021

I just confirmed that the doc is visible.

@hyangah hyangah added the pkgsite/license Issues related to licenses on pkg.go.dev. See our license policy https://pkg.go.dev/license-policy label May 20, 2022
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/license Issues related to licenses on pkg.go.dev. See our license policy https://pkg.go.dev/license-policy pkgsite
Projects
None yet
Milestone
pkgsite/license
Development

No branches or pull requests
5 participants
@hyangah @gopherbot @jamalc @jba @diegocarrion-wk