Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: panic during export method expression [1.17 backport] #48102

Closed
gopherbot opened this issue Aug 31, 2021 · 2 comments
Closed

cmd/compile: panic during export method expression [1.17 backport] #48102

gopherbot opened this issue Aug 31, 2021 · 2 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 31, 2021

@cuonglm requested issue #48088 to be considered for backport to the next 1.17 minor release.

@gopherbot please open a backport to go1.17

@gopherbot gopherbot added this to the Go1.17.1 milestone Aug 31, 2021
@cuonglm cuonglm changed the title cmd/compile: panic in escape analysis [1.17 backport] cmd/compile: panic during export method expression [1.17 backport] Aug 31, 2021
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 1, 2021

Change https://golang.org/cl/346670 mentions this issue: [release-branch.go1.17] cmd/compile: fix method expression lookup during import

Loading

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 1, 2021

Closed by merging 3969694 to release-branch.go1.17.

Loading

@gopherbot gopherbot closed this Sep 1, 2021
gopherbot pushed a commit that referenced this issue Sep 1, 2021
…ing import

CL 309831 fixed importing of method expressions, by re-using the same
code already have for ODOTMETH. But that code does not work with
embedded field.

To fix this, we need to calculate all methods of the receiver base type
of method expression, before looking up the selection.

Fixes #48102

Change-Id: Ia244d36a3ed0f989735eb57becdfa70a81912f57
Reviewed-on: https://go-review.googlesource.com/c/go/+/346489
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/346670
Reviewed-by: Keith Randall <khr@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants