Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: -keepfuzzing needs renaming, does not exist #48127

Open
rsc opened this issue Sep 2, 2021 · 7 comments
Open

cmd/go: -keepfuzzing needs renaming, does not exist #48127

rsc opened this issue Sep 2, 2021 · 7 comments
Labels
fuzz NeedsFix
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Sep 2, 2021

Generally, we try to keep the flag names big-endian, so that related flags all have a common prefix, like bench, benchtime, benchmem; memprofile, memprofilerate; even fuzz, fuzzcachedir, fuzzminimizetime, fuzztime, fuzzworker.

The exception in the go help testflag output is keepfuzzing, which doesn't begin with fuzz. It probably should. Maybe fuzzmore?

Also the flag seems not to be implemented.

% gotip test -v -fuzz=Fuzz -keepfuzzing
flag provided but not defined: -keepfuzzing
Usage of /tmp/go-build1779596492/b001/pkg.test:
	...

/cc @jayconrod @katiehockman

@rsc rsc added NeedsFix release-blocker labels Sep 2, 2021
@rsc rsc added this to the Go1.18 milestone Sep 2, 2021
@ameowlia
Copy link
Contributor

@ameowlia ameowlia commented Sep 2, 2021

fuzzforever? fuzzon? fuzznonstop?

@rsc
Copy link
Contributor Author

@rsc rsc commented Sep 3, 2021

fuzzcontinue would probably be fine.

@toothrot toothrot added the fuzz label Sep 22, 2021
@katiehockman
Copy link
Contributor

@katiehockman katiehockman commented Sep 28, 2021

https://go-review.googlesource.com/c/go/+/351113 removed the documentation for -keepfuzzing since it likely won't make it into this release. (And can always be added back if it does for whatever reason)
So I'll remove the release-blocker label.

-fuzzcontinue seems reasonable to me for when we implement it.

@rogpeppe
Copy link
Contributor

@rogpeppe rogpeppe commented Oct 5, 2021

FWIW I'd expect this to be the default - if I'm leaving something fuzzing for days or weeks (as I'm doing currently), I don't want it to stop immediately it finds a crash.
I was surprised when I found out that it did.

Possible flag name: -fuzzonce with the opposite sense to -fuzzcontinue? -fuzzstoponfail ?

@cespare
Copy link
Contributor

@cespare cespare commented Oct 5, 2021

@rogpeppe or use the existing -failfast flag?

(Though I'm not sure I agree about inverting the default behavior.)

@AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Oct 29, 2021

or use the existing -failfast flag?

See #45690

@katiehockman katiehockman removed this from the Go1.18 milestone Nov 10, 2021
@katiehockman katiehockman added this to the Go1.19 milestone Nov 10, 2021
@katiehockman
Copy link
Contributor

@katiehockman katiehockman commented Nov 10, 2021

This won't happen for 1.18, but I'd like to see it in 1.19. Updated the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzz NeedsFix
Projects
None yet
Development

No branches or pull requests

7 participants