Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: cannot highlight AST lines in ssa.html #48133

Closed
Zheng-Xu opened this issue Sep 2, 2021 · 5 comments
Closed

cmd/compile: cannot highlight AST lines in ssa.html #48133

Zheng-Xu opened this issue Sep 2, 2021 · 5 comments

Comments

@Zheng-Xu
Copy link
Contributor

@Zheng-Xu Zheng-Xu commented Sep 2, 2021

What version of Go are you using (go version)?

$ go version
go version devel go1.18-7622e41c84 Mon Aug 30 22:09:22 2021 +0000 linux/arm64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

  1. GOSSAFUNC=main.test go build test.go
  2. Open ssa.html in browser.
  3. Click any lines in any sections other than AST section.
  4. Click any lines in AST section.

What did you expect to see?

Corresponding lines in AST section should be highlight from step 3.
Lines in different sections(including AST) should be highlighted from step 4.

What did you see instead?

No line highlight in AST section from step 3.
No line highlight in any sections from step 4.

This issue was introduced by CL 275785

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 2, 2021

Change https://golang.org/cl/347269 mentions this issue: cmd/compile/internal/ir: better AST line highlight in ssa.html

Loading

@cherrymui cherrymui changed the title Cannot highlight AST lines in ssa.html cmd/compile: cannot highlight AST lines in ssa.html Sep 2, 2021
@cherrymui cherrymui added this to the Backlog milestone Sep 2, 2021
@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Sep 2, 2021

Loading

@erifan
Copy link
Contributor

@erifan erifan commented Sep 3, 2021

This is a regression since Go1.17, should we backport it to Go1.17 ?

Loading

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Sep 3, 2021

No. We only backport serious issues without workarounds. This is clearly not serious. And ssa.html is mostly for compiler developers, not for general users.

Loading

@erifan
Copy link
Contributor

@erifan erifan commented Sep 3, 2021

No. We only backport serious issues without workarounds. This is clearly not serious. And ssa.html is mostly for compiler developers, not for general users.

Ok.

Loading

@gopherbot gopherbot closed this in 96ab854 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants