Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: output does not respect comma as millisecond separator [1.17 backport] #48177

Closed
gopherbot opened this issue Sep 3, 2021 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 3, 2021

@cherrymui requested issue #48037 to be considered for backport to the next 1.17 minor release.

@gopherbot please consider backporting it into 1.17. Thanks.

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Sep 15, 2021

This issue has been approved as it is a major issue without any viable workarounds.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 15, 2021

Change https://golang.org/cl/350149 mentions this issue: [release-branch.go1.17] time: propagate "," separator for fractional seconds into Format

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 15, 2021

Closed by merging e79c297 to release-branch.go1.17.

@gopherbot gopherbot closed this Sep 15, 2021
gopherbot pushed a commit that referenced this issue Sep 15, 2021
…seconds into Format

In CL 300996 that fixed issue #6189, we made Parse recognize
"," as a separator for fractional seconds.
However, we didn't modify Format to propagate the separator
verbatim from Parse. Without this change, we break prior
functionality that relied on a comma being used in Format.

For #48037
Fixes #48177

Change-Id: I6565a25e8657ca3747a58b25acba58f27cdcddc0
Reviewed-on: https://go-review.googlesource.com/c/go/+/345438
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Cherry Mui <cherryyz@google.com>
(cherry picked from commit e1c3f21)
Reviewed-on: https://go-review.googlesource.com/c/go/+/350149
Trust: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants