jayconrod opened this issue
Sep 8, 2021
· 2 comments
Assignees
Labels
NeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.
We use type aliases in testing/internal/testdeps to avoid an import cycle between testing and internal tests of internal/fuzz and the packages it depends on. That may be tripping something here.
Per discussion with @mdempsky, it sounds like this may be an overly strict test. We'll skip it on dev.fuzz for now, but we won't merge dev.fuzz into master before the test is fixed.
The text was updated successfully, but these errors were encountered:
jayconrod
added
Testing
An issue that has been verified to require only test changes, not just a test failure.
NeedsFix
The path to resolution is known, but the work has not been done.
labels
Sep 8, 2021
That failure looks like it's because std now includes package constraints, which can't be compiled with -G=0 (because it relies on generics).
I'm leaning towards just removing TestUnifiedCompare anyway. I feel like it's served its purpose of bootstrapping unified IR, and at this point preserving byte-for-byte identical output with -G=0 seems to slow down development more than help.
NeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.
3 participants
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
I noticed this when merging
master
intodev.fuzz
, originally at CL 347232 PS1. See test log. The error is:We use type aliases in
testing/internal/testdeps
to avoid an import cycle betweentesting
and internal tests ofinternal/fuzz
and the packages it depends on. That may be tripping something here.Per discussion with @mdempsky, it sounds like this may be an overly strict test. We'll skip it on
dev.fuzz
for now, but we won't mergedev.fuzz
intomaster
before the test is fixed.The text was updated successfully, but these errors were encountered: