Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: Add GOAMD64 builders for go1.18 #48505

Open
martisch opened this issue Sep 21, 2021 · 1 comment
Open

x/build: Add GOAMD64 builders for go1.18 #48505

martisch opened this issue Sep 21, 2021 · 1 comment

Comments

@martisch
Copy link
Contributor

@martisch martisch commented Sep 21, 2021

WIth #45453 we are introducing new compilation variants for AMD64. We should have dedicated builders that test these as these will make the go compiler use new instructions and generate different binaries in go1.18.

As far as I understand none of the current try or slow bots will test binaries that are generated with the new v2, v3, v4 setting of GOAMD64.

We can likely leave the v4 builder out for now as its unlikely to be used soon and if so we can defer having one until then.
If we need one we need to make sure that one runs on a cloud machine hardware that supports AVX512 (e.g. skylake server): https://en.wikipedia.org/wiki/X86-64#Microarchitecture_levels

/cc @mdempsky @dmitshur @cagedmantis @randall77

@gopherbot gopherbot added this to the Unreleased milestone Sep 21, 2021
@martisch martisch removed this from the Unreleased milestone Sep 21, 2021
@martisch martisch added this to the Go1.18 milestone Sep 21, 2021
@mvdan
Copy link
Member

@mvdan mvdan commented Oct 19, 2021

The builder would already have caught one regression that broke make.bash with v3 :) #49061

Since GOARCH=amd64 is very common, and the majority of machines out there can build with GOAMD64=v3, I would hope that such a builder would be a trybot, not a slowbot. This should help catch regressions before merging, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Go Release Team
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants