Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: API not detected #48509

Closed
changkun opened this issue Sep 21, 2021 · 3 comments
Closed

x/pkgsite: API not detected #48509

changkun opened this issue Sep 21, 2021 · 3 comments

Comments

@changkun
Copy link
Member

What is the URL of the page with the issue?

https://pkg.go.dev/golang.design/x/clipboard

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36

What did you do?

Visit the page

What did you expect to see?

See APIs as it was displayed in older versions, e.g. https://pkg.go.dev/golang.design/x/clipboard@v0.4.6

What did you see instead?

No API is displayed.

@gopherbot gopherbot added this to the Unreleased milestone Sep 21, 2021
@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 21, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Sep 21, 2021
@jba jba self-assigned this Sep 21, 2021
@jba jba removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 21, 2021
@jba
Copy link
Contributor

jba commented Sep 21, 2021

This is the same problem as #48451: by removing the // +build comments, the package won't work with go 1.16, and that's currently the version we use to process modules. The fix is to add back those comments.

@jba jba closed this as completed Sep 21, 2021
@changkun
Copy link
Member Author

Since there is no auto-refresh or auto-reprocessing, the module will not be processed again unless I release a new version. right?

But 1.17 is indeed a supported version, and backward compatible, how about an upgrade to 1.17?

@jba
Copy link
Contributor

jba commented Sep 22, 2021

We run on App Engine, which currently only supports 1.16. We'll upgrade as soon as we can.
Meanwhile, yes, you'd have to release a new version.

@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants