Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: create zip: malformed file path: invalid char '?' #48544

Closed
sfllaw opened this issue Sep 22, 2021 · 3 comments
Closed

x/pkgsite: create zip: malformed file path: invalid char '?' #48544

sfllaw opened this issue Sep 22, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/unplanned

Comments

@sfllaw
Copy link
Contributor

sfllaw commented Sep 22, 2021

What did you do?

GET the following URL from the Go module proxy:
https://proxy.golang.org/golang.org/x/pkgsite/@v/v0.0.0-20210921213514-5c86378aae4c.zip

(Obviously, you should try with the latest commit.)

What did you expect to see?

A zipped copy of the module.

What did you see instead?

not found: create zip: tests/e2e/__image_snapshots__/ci/unit-desktop--errors@go1.16.3?tab=imports-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-desktop--errors@go1.16.3?tab=imports-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-desktop--errors@go1.16.3?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-desktop--errors@go1.16.3?tab=licenses-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-desktop--github.com-apache-thrift@v0.14.1?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-desktop--github.com-apache-thrift@v0.14.1?tab=licenses-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-desktop--golang.org-x-tools@v0.1.1?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-desktop--golang.org-x-tools@v0.1.1?tab=licenses-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-desktop--rsc.io-quote?tab=versions-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-desktop--rsc.io-quote?tab=versions-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-desktop--std@go1.16.3?tab=imports-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-desktop--std@go1.16.3?tab=imports-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-desktop--std@go1.16.3?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-desktop--std@go1.16.3?tab=licenses-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-mobile--errors@go1.16.3?tab=imports-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-mobile--errors@go1.16.3?tab=imports-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-mobile--errors@go1.16.3?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-mobile--errors@go1.16.3?tab=licenses-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-mobile--github.com-apache-thrift@v0.14.1?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-mobile--github.com-apache-thrift@v0.14.1?tab=licenses-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-mobile--golang.org-x-tools@v0.1.1?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-mobile--golang.org-x-tools@v0.1.1?tab=licenses-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-mobile--rsc.io-quote?tab=versions-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-mobile--rsc.io-quote?tab=versions-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-mobile--std@go1.16.3?tab=imports-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-mobile--std@go1.16.3?tab=imports-snap.png": invalid char '?'
tests/e2e/__image_snapshots__/ci/unit-mobile--std@go1.16.3?tab=licenses-snap.png: malformed file path "tests/e2e/__image_snapshots__/ci/unit-mobile--std@go1.16.3?tab=licenses-snap.png": invalid char '?'
@gopherbot gopherbot added this to the Unreleased milestone Sep 22, 2021
@sfllaw
Copy link
Contributor Author

sfllaw commented Sep 22, 2021

This is possibly related to #30854?

@jamalc jamalc self-assigned this Sep 22, 2021
@jamalc jamalc added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 22, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Sep 22, 2021
@bcmills
Copy link
Contributor

bcmills commented Sep 22, 2021

See https://golang.org/ref/mod#zip-path-size-constraints for the relevant filesystem restrictions.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/351275 mentions this issue: tests/e2e: remove invalid characters from snapshot filenames

@rsc rsc unassigned jamalc Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@sfllaw @bcmills @gopherbot @jamalc