Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile/internal/ssa: TestInlineLines fails on Windows #48550

Closed
bcmills opened this issue Sep 22, 2021 · 3 comments
Closed

cmd/compile/internal/ssa: TestInlineLines fails on Windows #48550

bcmills opened this issue Sep 22, 2021 · 3 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Sep 22, 2021

CL 351529 removes a workaround for #43938 on Windows on the regression test for #47880.

Unfortunately, that workaround seems to have been masking another bug on Windows.
https://storage.googleapis.com/go-build-log/033ed565/windows-amd64-2016_fd7dc5ba.log:

--- FAIL: TestInlineLines (0.07s)
    debug_lines_test.go:173: wanted inlines [[3] [4] [5] [4 10] [4 10] [4 11] [5 10] [5 10] [5 11] [4 10 16] [4 11 16] [5 10 16] [5 11 16]] but got []
FAIL
FAIL	cmd/compile/internal/ssa	5.867s

The failing test was added in CL 348970 (CC @dr2chase, @randall77), so this appears to be a test-regression for Go 1.18. (It is not clear to me whether the test regression also represents a regression in functionality.)

@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented Sep 22, 2021

That's not an inlining bug, that's a bug in the regular expression for a path separator in the test.
We don't need this test to run on all OSes, so I would just leave it disabled on Windows like it originally was.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 23, 2021

Change https://golang.org/cl/351529 mentions this issue: cmd/compile/internal/ssa: remove workarounds for #43938

Loading

@bcmills
Copy link
Member Author

@bcmills bcmills commented Sep 23, 2021

Oh, that doesn't seem at all difficult to fix! I'll fold it in to CL 351529.

Loading

@gopherbot gopherbot closed this in 93f964b Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants