Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: type error analyzers should have the suggested fix as a message #48556

Open
stamblerre opened this issue Sep 22, 2021 · 0 comments
Open

x/tools/gopls: type error analyzers should have the suggested fix as a message #48556

stamblerre opened this issue Sep 22, 2021 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@stamblerre
Copy link
Contributor

Currently, the title of a type error analysis diagnostic has to match the type error for a type error analyzer to be recognized. However, this has the side effect of making the suggested fix title for a type error analyzer be the same as the message of the type error. This makes the suggested fixes confusing, as they don't say what they are actually doing.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 22, 2021
@gopherbot gopherbot added this to the Unreleased milestone Sep 22, 2021
@suzmue suzmue modified the milestones: Unreleased, gopls/unplanned Sep 23, 2021
@adonovan adonovan added the Refactoring Issues related to refactoring tools label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
4 participants
@adonovan @stamblerre @suzmue @gopherbot