Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: unsafe.Add bug when adding uint8 value to a pointer [1.17 backport] #48561

Closed
gopherbot opened this issue Sep 22, 2021 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 22, 2021

@ianlancetaylor requested issue #48536 to be considered for backport to the next 1.17 minor release.

@gopherbot Please open a backport issue to Go 1.17.

This appears to be a bug in the implementation of unsafe.Add. This should be fixed to avoid silent miscompilation of valid code.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 23, 2021

Change https://golang.org/cl/351593 mentions this issue: [release-branch.go1.17] cmd/compile: fix unsafe.Add with small-size offsets operands

Loading

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 6, 2021

Change https://golang.org/cl/354352 mentions this issue: [release-branch.go1.17] cmd/compile: fold handling OCONV logic to separate function

Loading

gopherbot pushed a commit that referenced this issue Oct 6, 2021
…arate function

So next CL can re-use the logic to perform checkptr instrumentation.

For #48561

Change-Id: I3241e9c3c84da04db71fd1d4fd83cb76b2e18521
Reviewed-on: https://go-review.googlesource.com/c/go/+/345435
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
(cherry picked from commit 8fad81c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/354352
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 6, 2021

Closed by merging b18ba59 to release-branch.go1.17.

Loading

@gopherbot gopherbot closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants