x/pkgsite: devtools/cmd/seeddb -bypass_license_check

[sfllaw]

What are you trying to do?

We are running a private instance of Pkg.go.dev against our internal GitHub Enterprise Server. Like most companies, we do not bother to write LICENSE files, but would still like to see the documentation for our projects. This is why we run cmd/frontend -bypass_license_check.

What do you expect?

We also would like to run devtools/cmd/seeddb periodically to pull the most up-to-date documentation. However, this tool is hardcoded to always do the license check.

I suggest that we add the following flag to devtools/cmd/seeddb/main.go:

var bypassLicenseCheck = flag.Bool("bypass_license_check", false, "insert all data into the DB, even for non-redistributable paths")

In order to respect this flag, main.run needs to be changed so that:

	f := &worker.Fetcher{
		ProxyClient:  proxyClient,
		SourceClient: sourceClient,
	}

	if *bypassLicenseCheck {
		f.DB = postgres.NewBypassingLicenseCheck(db)
	} else {
		f.DB = postgres.New(db)
	}

[sfllaw]

This is related to #39602.

[sfllaw]

@jba: I couldn’t convince you to look into this one too, could I? 🙂

[jba]

This is reasonable.

[gopherbot]

Change https://golang.org/cl/352900 mentions this issue: devtools/cmd/seeddb: support bypassing the license check