Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools: unified and longest builds are failing on the constraints package #48595

Open
findleyr opened this issue Sep 24, 2021 · 5 comments
Open

x/tools: unified and longest builds are failing on the constraints package #48595

findleyr opened this issue Sep 24, 2021 · 5 comments

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Sep 24, 2021

As of https://golang.org/cl/349709, which introduced the constraints package, the x/tools unified and longtest builders are failing, though in different ways.

Longtest builders are failing in go/ssa:
https://build.golang.org/log/5352d2134bdc9df4bef4a9e3dee22cc99d443e70
Perhaps it would suffice to skip standard library packages that use type parameters, for now.

Unified builders are failing in gcimporter: https://build.golang.org/log/5cdff1e5c507144f74953000b0c7335a32ea0587

The latter (unified) is a TryBot for x/tools, so should be fixed soon; I will take a look at it tomorrow.

CC @mdempsky @timothy-king @ianlancetaylor @griesemer

@gopherbot gopherbot added this to the Unreleased milestone Sep 24, 2021
@cuonglm

This comment has been hidden.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 24, 2021

Change https://golang.org/cl/352051 mentions this issue: go/ssa: skip the "constraints" package in TestStdlib

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 24, 2021

Change https://golang.org/cl/352050 mentions this issue: go/internal/gcimporter: temporarily skip the contraints package on the

Loading

gopherbot pushed a commit to golang/tools that referenced this issue Sep 24, 2021
unified builder

Temporary work-around to fix TryBots until the failure can be
investigated.

Updates golang/go#48595

Change-Id: Ifbc27fc4551195bd9c7427bab7a79076c6ba6392
Reviewed-on: https://go-review.googlesource.com/c/tools/+/352050
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopherbot pushed a commit to golang/tools that referenced this issue Sep 24, 2021
go/ssa doesn't yet support generics, so the "constraints" package causes
this test to fail.

Updates golang/go#48595

Change-Id: I11c5a944bffba0c0398cd48ffca5d80fbede4332
Reviewed-on: https://go-review.googlesource.com/c/tools/+/352051
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@zpavlinovic
Copy link
Contributor

@zpavlinovic zpavlinovic commented Sep 28, 2021

Likely related #48525

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 28, 2021

Change https://golang.org/cl/352853 mentions this issue: go/internal/gcimporter: skip typeparam import tests on unified builders

Loading

gopherbot pushed a commit to golang/tools that referenced this issue Sep 28, 2021
CL 351855 introduced a typeparam test that imported the constraints
package. As reported in golang/go#48595, this package is currently
breaking with the unified export data format.

Updates golang/go#48595

Change-Id: I1b77955c767a2e890d8d8829cca6455a4e79c5ee
Reviewed-on: https://go-review.googlesource.com/c/tools/+/352853
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants