Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Remove hardcoded references to pkg.go.dev #48603

Open
sfllaw opened this issue Sep 24, 2021 · 0 comments
Open

x/pkgsite: Remove hardcoded references to pkg.go.dev #48603

sfllaw opened this issue Sep 24, 2021 · 0 comments
Labels
NeedsInvestigation pkgsite

Comments

@sfllaw
Copy link
Contributor

@sfllaw sfllaw commented Sep 24, 2021

Bug

There are quite a few places where the strings “pkg.go.dev” and “beta.pkg.go.dev” are hardcoded into pkgsite.

When self-hosting, this causes a few bugs, especially where pkgsite redirects the user to https://pkg.go.dev instead of the current host.

Proposal

I suggest we add a Config.SiteName field that defaults to “https://pkg.go.dev” which should be overridden by a GO_DISCOVERY_SITE_NAME environment variable.

It would probably be useful in templates if a Config.SitePath(string) helper method could append an arbitrary path to the site name.

Links

Search: “pkg.go.dev” literal, excluding tests: pkg.go.dev repo:^github\.com/golang/pkgsite$ -file:\.md$ -file:_test\.go$ -file:^tests/ -file:testdata/

Related: #39827

@gopherbot gopherbot added this to the Unreleased milestone Sep 24, 2021
@jamalc jamalc added the NeedsInvestigation label Oct 4, 2021
@jamalc jamalc removed this from the Unreleased milestone Oct 4, 2021
@jamalc jamalc added this to the pkgsite/unplanned milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants