Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: TestTimeVDSO is flaky on android builders #48655

Open
cherrymui opened this issue Sep 27, 2021 · 7 comments
Open

runtime/pprof: TestTimeVDSO is flaky on android builders #48655

cherrymui opened this issue Sep 27, 2021 · 7 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Milestone

Comments

@cherrymui
Copy link
Member

cherrymui commented Sep 27, 2021

#!watchflakes
post <- goos == "android" && test == "TestTimeVDSO"

CL https://go-review.googlesource.com/c/go/+/337590 added a test TestTimeVDSO. But it is flaky on Android builders. I'll look into it.

@cherrymui cherrymui self-assigned this Sep 27, 2021
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android labels Sep 27, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Nov 4, 2021

This flaky TestTimeVDSO failure happened at least once also on linux/amd64:

--- FAIL: TestTimeVDSO (5.00s)
    pprof_test.go:514: total 0 CPU profile samples collected:
    pprof_test.go:530: too few samples; got 0, want at least 125, ideally 500
    pprof_test.go:549: time.now: 0
    pprof_test.go:552: no samples in expected functions
    pprof_test.go:562: time.now has 0 samples out of 0, want at least 1, ideally 0

(Build log.)

From a slowbot run on CL 361294. It didn't happen on the first retry.

@bcmills bcmills closed this as completed Jun 14, 2022
@bcmills
Copy link
Contributor

bcmills commented Jun 14, 2022

Oop, no. a skip was added in CL 352509 but we forgot to refer to this issue in the commit message.

@bcmills bcmills reopened this Jun 14, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
@seankhliao seankhliao added this to the Unplanned milestone Aug 20, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/455358 mentions this issue: runtime/pprof: unskip TestTimeVDSO on Android

@cherrymui
Copy link
Member Author

Reverted. Still flaky.

@cherrymui cherrymui reopened this Dec 6, 2022
@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "android" && test == "TestTimeVDSO"
2022-12-06 20:19 android-amd64-emu go@5167e5cd runtime/pprof.TestTimeVDSO (log)
--- FAIL: TestTimeVDSO (103.61s)
    pprof_test.go:539: total 8 CPU profile samples collected:
        8: 0x7997c917eeb6 (time.Now:1111) 0x7997c9262d11 (runtime/pprof.TestTimeVDSO.func1:2269) 0x7997c9250bd9 (runtime/pprof.testCPUProfile:465) 0x7997c925dda4 (runtime/pprof.TestTimeVDSO:2266) 0x7997c91d3f0a (testing.tRunner:1575) labels: map[]

    pprof_test.go:610: time.now: 0
    pprof_test.go:613: no samples in expected functions
    pprof_test.go:624: time.now has 0 samples out of 0, want at least 1, ideally 0
    pprof_test.go:476: retrying with 200ms duration
    pprof_test.go:539: total 16 CPU profile samples collected:
        16: 0x7997c917eeb6 (time.Now:1111) 0x7997c9262d11 (runtime/pprof.TestTimeVDSO.func1:2269) 0x7997c9250bd9 (runtime/pprof.testCPUProfile:465) 0x7997c925dda4 (runtime/pprof.TestTimeVDSO:2266) 0x7997c91d3f0a (testing.tRunner:1575) labels: map[]
...
        2: 0x7997c9167084 (runtime.nanotime:19 time.Sleep:191) 0x7997c924254b (runtime/pprof.profileWriter:809) labels: map[]

        1: 0x7997c9102e2e (runtime/internal/syscall.Syscall6:36) 0x7997c9102da8 (runtime/internal/syscall.EpollWait:55) 0x7997c91319f8 (runtime.netpoll:117) 0x7997c913db26 (runtime.findRunnable:2971) 0x7997c913ecb0 (runtime.schedule:3360) 0x7997c913f1cc (runtime.park_m:3511) 0x7997c9168004 (runtime.mcall:452) labels: map[]

        1: 0x7997c917eecd (time.Now:1114) 0x7997c9262d11 (runtime/pprof.TestTimeVDSO.func1:2269) 0x7997c9250bd9 (runtime/pprof.testCPUProfile:465) 0x7997c925dda4 (runtime/pprof.TestTimeVDSO:2266) 0x7997c91d3f0a (testing.tRunner:1575) labels: map[]

    pprof_test.go:610: time.now: 0
    pprof_test.go:613: no samples in expected functions
    pprof_test.go:624: time.now has 0 samples out of 0, want at least 1, ideally 0
exitcode=1

watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "android" && test == "TestTimeVDSO"
2022-12-06 18:32 android-amd64-emu go@dfd13ce5 runtime/pprof.TestTimeVDSO (log)
--- FAIL: TestTimeVDSO (103.60s)
    pprof_test.go:539: total 7 CPU profile samples collected:
        7: 0x7227ef0a3eb6 (time.Now:1111) 0x7227ef187d11 (runtime/pprof.TestTimeVDSO.func1:2269) 0x7227ef175bd9 (runtime/pprof.testCPUProfile:465) 0x7227ef182da4 (runtime/pprof.TestTimeVDSO:2266) 0x7227ef0f8f0a (testing.tRunner:1575) labels: map[]

    pprof_test.go:610: time.now: 0
    pprof_test.go:613: no samples in expected functions
    pprof_test.go:624: time.now has 0 samples out of 0, want at least 1, ideally 0
    pprof_test.go:476: retrying with 200ms duration
    pprof_test.go:539: total 20 CPU profile samples collected:
        20: 0x7227ef0a3eb6 (time.Now:1111) 0x7227ef187d11 (runtime/pprof.TestTimeVDSO.func1:2269) 0x7227ef175bd9 (runtime/pprof.testCPUProfile:465) 0x7227ef182da4 (runtime/pprof.TestTimeVDSO:2266) 0x7227ef0f8f0a (testing.tRunner:1575) labels: map[]
...
        1: 0x7227ef062240 (runtime.execute:2628) 0x7227ef063dfb (runtime.schedule:3398) 0x7227ef0642c9 (runtime.goschedImpl:3526) 0x7227ef0645b4 (runtime.gopreempt_m:3554) 0x7227ef074939 (runtime.newstack:1072) 0x7227ef08d13f (runtime.morestack:574) labels: map[]

        1: 0x7227ef02eda0 (runtime.readUnaligned64:352 runtime.r8:91 runtime.memhash64Fallback:77) 0x7227ef036223 (runtime.mapaccess1_fast64:29) 0x7227ef162c75 (runtime/pprof.(*profMap).lookup:41) 0x7227ef16acc8 (runtime/pprof.(*profileBuilder).addCPUData:338) 0x7227ef167584 (runtime/pprof.profileWriter:811) labels: map[]

        1: 0x7227ef0a3aca (time.Time.Sub:884) 0x7227ef187d25 (runtime/pprof.TestTimeVDSO.func1:2270) 0x7227ef175bd9 (runtime/pprof.testCPUProfile:465) 0x7227ef182da4 (runtime/pprof.TestTimeVDSO:2266) 0x7227ef0f8f0a (testing.tRunner:1575) labels: map[]

    pprof_test.go:610: time.now: 0
    pprof_test.go:613: no samples in expected functions
    pprof_test.go:624: time.now has 0 samples out of 0, want at least 1, ideally 0
exitcode=1

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Projects
Status: In Progress
Status: Done
Development

No branches or pull requests

5 participants