x/pkgsite: deprecated UI is overly repetitive #48678
Take a look at https://pkg.go.dev/path/filepath#HasPrefix:
I see deprecated as many as three times: next to the declaration in the form of a label, in the "This function has been deprecated." notice below, and in the "Deprecated:" text in the original godoc.
I get that the label should be there, to still be clear when one presses "hide". And that the "Deprecated:" text is part of the original godoc, so we should probably not alter the text.
That leaves me with the extra notice in between, which I think doesn't add much information. Here's an example of how it looks like when we remove that extra notice - in my opinion, better:
The text was updated successfully, but these errors were encountered: