Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: deprecation background color is too bright on dark mode #48679

Closed
mvdan opened this issue Sep 29, 2021 · 5 comments
Closed

x/pkgsite: deprecation background color is too bright on dark mode #48679

mvdan opened this issue Sep 29, 2021 · 5 comments

Comments

@mvdan
Copy link
Member

@mvdan mvdan commented Sep 29, 2021

Take a look at how https://pkg.go.dev/path/filepath#HasPrefix looks on the light theme:

image

And now the dark theme:

image

The yellow color changes, and I think the intent was to make it darker for the dark theme. But instead, we simply get a far more striking yellow, that's nearly as bright as the light theme's.

On one hand, I find the black text much harder to read on the dark theme - the stronger yellow background distracts my eyes.

On the other hand, the stronger yellow seems to go against the purpose of the dark theme - to be easy on the eyes and not be too bright. If I open that page on the dark theme in a dark room, the yellow stands out significantly, and can easily light up my entire face yellow :)

For example, using my amazing non-existent design skills, here's how it looks if I keep the text color following the theme, and change the dark warning background to be a darker yellow color, #906e00:

image

I'm sure it looks horrible to anyone with UI skills, but at least it looks more like a readable dark theme to me :)

cc @julieqiu

@gopherbot gopherbot added this to the Unreleased milestone Sep 29, 2021
@mvdan
Copy link
Member Author

@mvdan mvdan commented Sep 29, 2021

I tried to go for even darker yellows, closer to either gray or black, but they started looking more like brown or weird greens, so I don't know if that can fly.

In any case, I want the color to not jump out as much, just like it doesn't in the light theme.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Sep 29, 2021

@julieqiu julieqiu removed this from the Unreleased milestone Sep 29, 2021
@julieqiu julieqiu added this to the pkgsite/frontend milestone Sep 29, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2021

Change https://golang.org/cl/355190 mentions this issue: static: improve dark mode UI

@jamalc
Copy link

@jamalc jamalc commented Oct 11, 2021

The recommendation we're getting from UX is just a reduction in saturation. It looks fine to me. Any objections?

Screen Shot 2021-10-11 at 3 40 25 PM

@mvdan
Copy link
Member Author

@mvdan mvdan commented Oct 12, 2021

@jamalc that looks significantly better than what we have now indeed :) And certainly prettier than the color I came up with.

@gopherbot gopherbot closed this in d5bd14b Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants