Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: missing functions for unexported embedded struct #48722

gonutz opened this issue Oct 1, 2021 · 1 comment

x/pkgsite: missing functions for unexported embedded struct #48722

gonutz opened this issue Oct 1, 2021 · 1 comment
NeedsInvestigation pkgsite


Copy link

@gonutz gonutz commented Oct 1, 2021

The wui library documentation is missing some functions.

Take the Button: it has an embedded textContol struct which in turn embeds control which has exported function SetX. Here are the code links:

control.SetX(x int)

Now the documentation does not list SetX under the Button type.

This is true for a number of types but not for all of them.

As a counter example, SetX is documented to be part of FloatUpDown which has one more indirection by embedding textEditControl, which then embeds textControl as above.


I suspect this might be a corner case with unexported embedded structs which have exported functions.

@gopherbot gopherbot added this to the Unreleased milestone Oct 1, 2021
Copy link

@go101 go101 commented Oct 2, 2021

dup of #6600?

BTW, Golds shows them all:

@jamalc jamalc added the NeedsInvestigation label Oct 4, 2021
@jamalc jamalc removed this from the Unreleased milestone Oct 4, 2021
@jamalc jamalc added this to the pkgsite/unplanned milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
NeedsInvestigation pkgsite
None yet

No branches or pull requests

4 participants