Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/fuzz: improperly handling crash that occurs while minimizing interesting input #48731

Closed
katiehockman opened this issue Oct 1, 2021 · 2 comments

Comments

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Oct 1, 2021

Found a very niche bug when trying things out locally. There is one case I've found where minimization doesn't occur, when it should.

To reproduce, run the target in #48320 with go test -run Fuzz -fuzz Fuzz -v. This happens consistently whenever there is something in the interesting cache and when -parallel is greater than 1.

Using the debugger, I was able to narrow it down to this scenario:
While fuzzing, an input which expands coverage is found. When minimizing said input, a new crash occurs. Currently, minimization is shut off if a crash is found during minimization

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 1, 2021

Change https://golang.org/cl/353355 mentions this issue: testing: write output to buffer when fuzzing

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2021

Change https://golang.org/cl/355691 mentions this issue: internal/fuzz: fix bugs with minimization

@gopherbot gopherbot closed this in cfe6763 Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants