Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gomote: add authentication to gomote client #48739

Open
cagedmantis opened this issue Oct 1, 2021 · 2 comments
Open

x/build/cmd/gomote: add authentication to gomote client #48739

cagedmantis opened this issue Oct 1, 2021 · 2 comments

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Oct 1, 2021

This tracks the adding of Identity Aware Proxy authentication (OATH2) to the gomote client.

This is a component of the project to revamp the security model used by gomote #47521
@golang/release

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 3, 2021

Change https://golang.org/cl/361194 mentions this issue: internal/iapclient: create

Loading

gopherbot pushed a commit to golang/build that referenced this issue Nov 4, 2021
iapclient enables command-line, programmatic access to our IAP-protected
sites. For now, it's quite specific to the command-line case; we can
make it more flexible in the future if necessary.

There are no tests, because I have no idea how to write a meaningful
automated test of this code.

For golang/go#48739.

Change-Id: Ibbc33ae045c6e5b68eee34900fe0a791d3a48558
Reviewed-on: https://go-review.googlesource.com/c/build/+/361194
Trust: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 29, 2021

Change https://golang.org/cl/367535 mentions this issue: internal/iapclient: create configuration directory

Loading

gopherbot pushed a commit to golang/build that referenced this issue Nov 29, 2021
The configuration directory must be created before the token is stored
in it. This change ensures that the directory exists before attempting
to store the newly created token in it.

Updates golang/go#48739

Change-Id: I2db71485c166ba094e61690533849c33913a5530
Reviewed-on: https://go-review.googlesource.com/c/build/+/367535
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants