Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: tests have gotten slower #48770

Open
josharian opened this issue Oct 4, 2021 · 2 comments
Open

runtime: tests have gotten slower #48770

josharian opened this issue Oct 4, 2021 · 2 comments

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Oct 4, 2021

I've noticed running all.bash recently that the runtime tests are really slow and CPU intensive.

On my M1, I tried doing cd $GOROOT/runtime; go test -c; ./runtime.test -test.short with recent Go versions. The runtime tests now take almost 3x longer than 1.17.

  • Go 1.16: 6.46 real 7.76 user 2.52 sys
  • Go 1.17: 7.39 real 8.40 user 2.48 sys
  • Tip, Oct 4 '21 (9432320): 20.03 real 25.64 user 6.26 sys

The slowest at tip are:

0.50s TestCgoCrashHandler
0.58s TestCgoExternalThreadSignal
0.67s TestCgoSignalDeadlock
0.71s TestCheckPtr2
0.72s TestCgoExternalThreadSIGPROF
0.77s TestEINTR
1.00s TestCheckPtr/CheckPtrAlignmentNilPtr
1.00s TestDeferKeepAlive
1.01s TestSpuriousWakeupsNeverHangSemasleep
1.13s TestVDSO
1.38s TestCgoCCodeSIGPROF

Perhaps some of these could be shortened, skipped, or marked parallel?

@cuonglm
Copy link
Member

@cuonglm cuonglm commented Oct 4, 2021

Maybe related #48496

@josharian
Copy link
Contributor Author

@josharian josharian commented Oct 4, 2021

Ouch. Yes, quite possibly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants