x/tools/gopls/internal/regtest/diagnostics: TestQuickFixEmptyFiles failing frequently on small/slow builders #48773

bcmills · 2021-10-04T19:14:58Z

greplogs --dashboard -md -l -e 'FAIL: TestQuickFixEmptyFiles'

CC @stamblerre

The text was updated successfully, but these errors were encountered:

bcmills · 2021-10-04T19:15:12Z

At this failure rate, this is a release-blocker for Go 1.18 via #11811.

dmitshur · 2021-10-27T16:22:37Z

CC @golang/release.

dmitshur · 2021-11-03T16:22:59Z

We should check if this is a problem with the builder having insufficient specs, otherwise it's a problem with test.

gopherbot · 2021-11-03T19:25:06Z

Change https://golang.org/cl/361157 mentions this issue: internal/regtest: skip TestQuickFixEmptyFiles: it is too flaky

Updates golang/go#48773 Change-Id: Ic11f0a78c8ef13349fb521fe9a276dabeb574d4b Reviewed-on: https://go-review.googlesource.com/c/tools/+/361157 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org>

findleyr · 2021-11-05T17:50:28Z

This test is skipped now. It's still a bug in gopls, but independent of the build flakiness this is not a release blocker.

ianlancetaylor · 2022-01-29T00:22:16Z

@findleyr This is in the 1.18 milestone; time to move to 1.19? Thanks.

dmitshur · 2022-02-01T01:18:20Z

Since it's no longer a release-blocker, and the relevant x/tools package isn't vendored in Go, I think we can move this back to Unreleased milestone.

gopherbot · 2022-07-22T15:46:24Z

Change https://go.dev/cl/419106 mentions this issue: gopls/internal/regtest: unskip TestQuickFixEmptyFiles

This test ran slowly sometimes. Now that we have improved performance, elimininated arbitrary timeouts, and improved cacheability of computed results when running with -short, I suspect this test should no longer flake. If it does, we can reduce its cost in other ways rather than turning it off entirely. Updates golang/go#48773 Updates golang/go#53878 Change-Id: I878e78117df5a1a25f4ac5f72e02f28fc078ec73 Reviewed-on: https://go-review.googlesource.com/c/tools/+/419106 Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>

findleyr · 2022-08-08T13:31:29Z

Looks like this is no longer flaky.

> greplogs --dashboard -md -l -e 'FAIL: TestQuickFixEmptyFiles' --since=2022-07-14
>

gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 4, 2021

gopherbot added this to the Unreleased milestone Oct 4, 2021

bcmills added the release-blocker label Oct 4, 2021

bcmills modified the milestones: Unreleased, Go1.18 Oct 4, 2021

bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 4, 2021

stamblerre assigned stamblerre and unassigned stamblerre Oct 13, 2021

findleyr removed the release-blocker label Nov 5, 2021

findleyr mentioned this issue Nov 5, 2021

x/tools/gopls: IWL progress report canceled and not marked as done #46930

Closed

dmitshur modified the milestones: Go1.18, Unreleased Feb 1, 2022

findleyr modified the milestones: Unreleased, gopls/on-deck Feb 3, 2022

findleyr added the gopls/testing label Apr 11, 2022

findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022

findleyr mentioned this issue Jul 14, 2022

x/tools/gopls: unskip all previously flaky regtests #53878

Closed

8 tasks

findleyr closed this as completed Aug 8, 2022

findleyr modified the milestones: gopls/later, gopls/v0.9.2 Aug 8, 2022

findleyr self-assigned this Aug 8, 2022

golang locked and limited conversation to collaborators Aug 8, 2023

gopherbot added the FrozenDueToAge label Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls/internal/regtest/diagnostics: TestQuickFixEmptyFiles failing frequently on small/slow builders #48773

x/tools/gopls/internal/regtest/diagnostics: TestQuickFixEmptyFiles failing frequently on small/slow builders #48773

bcmills commented Oct 4, 2021

bcmills commented Oct 4, 2021

dmitshur commented Oct 27, 2021

dmitshur commented Nov 3, 2021

gopherbot commented Nov 3, 2021

findleyr commented Nov 5, 2021

ianlancetaylor commented Jan 29, 2022

dmitshur commented Feb 1, 2022

gopherbot commented Jul 22, 2022

findleyr commented Aug 8, 2022

x/tools/gopls/internal/regtest/diagnostics: TestQuickFixEmptyFiles failing frequently on small/slow builders #48773

x/tools/gopls/internal/regtest/diagnostics: TestQuickFixEmptyFiles failing frequently on small/slow builders #48773

Comments

bcmills commented Oct 4, 2021

bcmills commented Oct 4, 2021

dmitshur commented Oct 27, 2021

dmitshur commented Nov 3, 2021

gopherbot commented Nov 3, 2021

findleyr commented Nov 5, 2021

ianlancetaylor commented Jan 29, 2022

dmitshur commented Feb 1, 2022

gopherbot commented Jul 22, 2022

findleyr commented Aug 8, 2022